Re: [PATCH v3 62/77] ncr5380: Implement new eh_bus_reset_handler

Hannes Reinecke
2015-12-22T08:01:43Z

On 12/22/2015 02:18 AM, Finn Thain wrote:
> NCR5380.c lacks a sane eh_bus_reset_handler. The atari_NCR5380.c code is
> much better but it should not throw out the issue queue (that would be
> a host reset) and it neglects to set the result code for commands that it
> throws out. Fix these bugs and keep the two core drivers in sync.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
> ---
> drivers/scsi/NCR5380.c | 50 ++++++++++++++++++++++++++++++++++++++++++-
> drivers/scsi/atari_NCR5380.c | 39 +++++++++++++++++++--------------
> 2 files changed, 72 insertions(+), 17 deletions(-)
>
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)