Re: [PATCH v3 51/77] ncr5380: Remove command list debug code

Hannes Reinecke
2015-12-22T07:47:31Z

On 12/22/2015 02:18 AM, Finn Thain wrote:
> Some NCR5380 hosts offer a .show_info method to access the contents of
> the various command list data structures from a procfs file. When NDEBUG
> is set, the same information is sent to the console during EH.
>
> The two core drivers, atari_NCR5380.c and NCR5380.c differ here. Because
> it is just for debugging, the easiest way to fix the discrepancy is
> simply remove this code.
>
> The only remaining users of NCR5380_show_info() and NCR5380_write_info()
> are drivers that define PSEUDO_DMA. The others have no use for the
> .show_info method, so don't initialize it.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
> ---
> drivers/scsi/NCR5380.c | 70 ++------------------------------
> drivers/scsi/arm/oak.c | 2
> drivers/scsi/atari_NCR5380.c | 94 +------------------------------------------
> drivers/scsi/atari_scsi.c | 2
> drivers/scsi/g_NCR5380.c | 1
> drivers/scsi/sun3_scsi.c | 2
> 6 files changed, 9 insertions(+), 162 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)