Re: [PATCH v3 23/77] ncr5380: Always retry arbitration and selection

Hannes Reinecke
2015-12-22T07:14:59Z

On 12/22/2015 02:18 AM, Finn Thain wrote:
> If NCR5380_select() returns -1, it means arbitration was lost or selection
> failed and should be retried. If the main loop simply terminates when there
> are still commands on the issue queue, they will remain queued until they
> expire.
>
> Fix this by clearing the 'done' flag after selection failure or lost
> arbitration.
>
> The "else break" clause in NCR5380_main() that gets removed here appears
> to be a vestige of a long-gone loop that iterated over host instances.
> See commit 491447e1fcff ("[PATCH] next NCR5380 updates") in
> history/history.git.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html