Re: [PATCH v3 37/77] ncr5380: Standardize work queueing algorithm

Hannes Reinecke
2015-12-22T07:33:16Z

On 12/22/2015 02:18 AM, Finn Thain wrote:
> The complex main_running/queue_main mechanism is peculiar to
> atari_NCR5380.c. It isn't SMP safe and offers little value given that
> the work queue already offers concurrency management. Remove this
> complexity to bring atari_NCR5380.c closer to NCR5380.c.
>
> It is not a good idea to call the information transfer state machine from
> queuecommand because, according to Documentation/scsi/scsi_mid_low_api.txt
> that could happen in soft irq context. Fix this.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
> ---
> drivers/scsi/NCR5380.h | 1
> drivers/scsi/atari_NCR5380.c | 80 +++----------------------------------------
> 2 files changed, 6 insertions(+), 75 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)