Re: [PATCH v3 67/77] ncr5380: Cleanup comments

Hannes Reinecke
2015-12-22T08:04:25Z

On 12/22/2015 02:18 AM, Finn Thain wrote:
> The CVS revision log is not nearly as useful as the history/history.git
> repo, so remove it. Roman's commentary at the top of his driver repeats
> the same information elsewhere in the file so remove it. Also remove
> some other redundant or obsolete comments.
>
> Both the driver and the datasheets confusingly refer to a DMA access
> for a SCSI WRITE command as a "DMA write". Similarly a SCSI READ command
> is called a "DMA read". This is the opposite of the usual convention.
> Thankfully, the chip documentation and driver code also use "DMA send" and
> "DMA receive", so adopt this terminology.
>
> This removes some unimportant discrepancies between the two core driver
> forks so that 'diff' can be used to reveal the important ones, to
> facilitate reunification.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
> ---
> drivers/scsi/NCR5380.c | 154 ++++++++++---------------------------------
> drivers/scsi/atari_NCR5380.c | 97 +++------------------------
> 2 files changed, 48 insertions(+), 203 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)