Re: [PATCH v3 47/77] ncr5380: Fix and cleanup scsi_host_template initializers

Hannes Reinecke
2015-12-22T07:43:18Z

On 12/22/2015 02:18 AM, Finn Thain wrote:
> Add missing .module initializer. Use distinct .proc_name values for the
> g_NCR5380 and g_NCR5380_mmio modules. Remove pointless CAN_QUEUE and
> CMD_PER_LUN override macros. Cleanup whitespace and code style.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
> ---
> drivers/scsi/atari_scsi.c | 2 +-
> drivers/scsi/dmx3191d.c | 1 +
> drivers/scsi/dtc.c | 32 ++++++++++++++++----------------
> drivers/scsi/dtc.h | 8 --------
> drivers/scsi/g_NCR5380.c | 26 +++++++++++++-------------
> drivers/scsi/g_NCR5380.h | 10 ++--------
> drivers/scsi/mac_scsi.c | 28 ++++++++++++++--------------
> drivers/scsi/pas16.c | 32 ++++++++++++++++----------------
> drivers/scsi/pas16.h | 8 --------
> drivers/scsi/sun3_scsi.c | 6 +++---
> drivers/scsi/t128.c | 32 ++++++++++++++++----------------
> drivers/scsi/t128.h | 8 --------
> 12 files changed, 82 insertions(+), 111 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)