Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

Joe Perches
2016-01-03T22:13:53Z

On Sun, 2016-01-03 at 22:05 +0000, One Thousand Gnomes wrote:
> On Sun, 03 Jan 2016 13:46:22 -0800
> Joe Perches <joe@perches.com> wrote:
>
> > (using an email address for James that shouldn't bounce)
> >
> > On Sun, 2016-01-03 at 21:29 +0000, One Thousand Gnomes wrote:
> > > > > I would beg to differ. As a tool for understanding the
> > > > > differences as you
> > > > > step through the versions it's invaluable.
> > > >
> > > > This removes intentional formatting that
> > > > makes reading comments easier.
> > >
> > > And this matters at the end of the patch series because ?
> >
> > It removes intentional formatting that makes
> > reading comments easier.
>
> I'm missing something here - the final result of the merge is completely
> and easily readable. Likewise I can work through it and review the code
> and compare them for the platform I care about (Mac68K)
>
> > And diff -w still works just fine.
>
> So you think 70+ patches should be redone because of that, when the end
> result is a clean driver anyway ???

Nope, I think patch 69 should simply not be applied.

I don't know and don't care if patches 70 through 78
depend on any changes made by patch 69.

I'd expect no dependencies exist though.

It doesn't matter much in any case.

cheers, Joe