Re: [PATCH v3 20/23] atari_scsi: Set a reasonable default for cmd_per_lun

Hannes Reinecke
2016-03-23T07:28:56Z

On 03/21/2016 03:32 AM, Finn Thain wrote:
> This setting does not need to be conditional on Atari ST or TT.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> Tested-by: Michael Schmitz <schmitzmic@gmail.com>
>
> ---
>
> Changed since v1:
> - Set the default cmd_per_lun to 4 based on test results.
>
> Changed since v2:
> - Revert the default cmd_per_lun to 2, like in the v1 patch, because
> a uniform default across all ten 5380 wrapper drivers is worth more
> than a tiny improvement in one particular microbenchmark on one system.
> Michael tells me that 2 is also the best setting for his Atari Falcon.
>
> ---
> drivers/scsi/atari_scsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)