public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: "George Spelvin" <linux@horizon.com>
To: geert@linux-m68k.org, gregungerer@westnet.com.au,
	linux-m68k@lists.linux-m68k.org, linux@horizon.com
Subject: Re: [RFC PATCH 1/2] arch/m68k/lib/mulsi3.S: Optimize]
Date: 12 May 2016 16:52:17 -0400	[thread overview]
Message-ID: <20160512205217.19233.qmail@ns.horizon.com> (raw)
In-Reply-To: <57347B1E.9030108@westnet.com.au>

Thank you very much!

Greg Ungerer wrote:
> This syntax fails for me (using a binutils-2.25.1 based toolchain).
> Registers must be prefixed with a "%", so here %sp and %a0.
>
>   arch/m68k/lib/mulsi3.S: Assembler messages:
>   arch/m68k/lib/mulsi3.S:12: Error: syntax error -- statement `lea 4(sp),a0' ignored
> 
> That was compiling with just this one patch for a ColdFire target.

Well, *that* is an embarrassing oversight.  If you fix that obvious typo
(I used ":%s/[ad][01]/%&/g"), do you have a way of testing it?

Setting up a suitable Qemu environment is many times the effort needed
to write the code, so I was hoping someone with the facilities already
in place would be willing to test.

I've stared at the code and am convinced it's right, but I remember
Knuth's words: "Beware of bugs in the above code; I have only proved it
correct, not tried it."

  reply	other threads:[~2016-05-12 20:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 10:24 [RFC PATCH 1/2] arch/m68k/lib/mulsi3.S: Optimize] George Spelvin
2016-05-11 12:38 ` Greg Ungerer
2016-05-12  8:04   ` George Spelvin
2016-05-12  8:35     ` Andreas Schwab
2016-05-12 13:14     ` Greg Ungerer
2016-05-12 12:46 ` Greg Ungerer
2016-05-12 20:52   ` George Spelvin [this message]
2016-05-13  1:07     ` Greg Ungerer
2016-05-13  2:36       ` George Spelvin
2016-05-13  6:45         ` Greg Ungerer
2016-05-13  9:02           ` George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160512205217.19233.qmail@ns.horizon.com \
    --to=linux@horizon.com \
    --cc=geert@linux-m68k.org \
    --cc=gregungerer@westnet.com.au \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox