From: David Miller <davem@davemloft.net>
To: babu.moger@oracle.com
Cc: ysato@users.sourceforge.jp, geert@linux-m68k.org,
jonas@southpole.se, stefan.kristiansson@saunalahti.fi,
shorne@gmail.com, jejb@parisc-linux.org, deller@gmx.de,
viro@zeniv.linux.org.uk, mpe@ellerman.id.au,
peterz@infradead.org, mingo@redhat.com, jcmvbkbc@gmail.com,
linux-kernel@vger.kernel.org,
uclinux-h8-devel@lists.sourceforge.jp,
linux-m68k@vger.kernel.org, openrisc@lists.librecores.org,
linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs
Date: Fri, 09 Jun 2017 12:40:25 -0400 (EDT) [thread overview]
Message-ID: <20170609.124025.1597341888979066145.davem@davemloft.net> (raw)
In-Reply-To: <1496960243-196898-2-git-send-email-babu.moger@oracle.com>
From: Babu Moger <babu.moger@oracle.com>
Date: Thu, 8 Jun 2017 15:17:22 -0700
> While working on enabling queued rwlock on SPARC, found
> this following code in include/asm-generic/qrwlock.h
> which uses CONFIG_CPU_BIG_ENDIAN to clear a byte.
>
> static inline u8 *__qrwlock_write_byte(struct qrwlock *lock)
> {
> return (u8 *)lock + 3 * IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN);
> }
>
> Problem is many of the fixed big endian architectures dont define
> CPU_BIG_ENDIAN and clears the wrong byte.
>
> Define CPU_BIG_ENDIAN for all the fixed big endian architecture.
>
> Here is the orinal discussion
> http://www.spinics.net/lists/devicetree/msg178101.html
>
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2017-06-09 16:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 22:17 [PATCH 0/2] Define CPU_BIG_ENDIAN or warn for inconsistencies Babu Moger
2017-06-08 22:17 ` [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs Babu Moger
2017-06-09 7:03 ` Geert Uytterhoeven
2017-06-09 15:55 ` Babu Moger
2017-06-09 16:40 ` David Miller [this message]
2017-06-08 22:17 ` [PATCH 2/2] include: warn for inconsistent endian config definition Babu Moger
2017-06-09 7:05 ` Geert Uytterhoeven
2017-06-09 7:16 ` Geert Uytterhoeven
2017-06-09 13:55 ` Babu Moger
2017-06-09 14:11 ` Geert Uytterhoeven
2017-06-09 14:39 ` Babu Moger
2017-06-10 14:06 ` kbuild test robot
2017-06-12 20:30 ` Babu Moger
2017-06-12 20:51 ` Arnd Bergmann
2017-06-12 20:58 ` Max Filippov
2017-06-12 21:31 ` Babu Moger
2017-06-12 21:24 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609.124025.1597341888979066145.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=babu.moger@oracle.com \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=jcmvbkbc@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=openrisc@lists.librecores.org \
--cc=peterz@infradead.org \
--cc=shorne@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=viro@zeniv.linux.org.uk \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox