Re: [PATCH] m68k: mcfmmu: remove stale part of comment about steal_context

[Mike Rapoport <rppt@kernel.org>]

Hi Greg,

On Thu, Jun 18, 2020 at 09:48:42PM +1000, Greg Ungerer wrote:
> Hi Mike,
> 
> On 18/6/20 6:17 pm, Mike Rapoport wrote:
> > From: Mike Rapoport <rppt@linux.ibm.com>
> > 
> > The comment about steal_context() came from powerpc and a part of it
> > addresses differences between powerpc variants that are not really
> > relevant to m68k.
> > 
> > Remove that part of the comment.
> > 
> > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> 
> Acked-by: Greg Ungerer <gerg@linux-m68k.org>
> 
> Do you want me to carry that in my m68k (m68knommu) tree for v5.9?

Yes, please :)

> Regards
> Greg
> 
> 
> > ---
> > Hi,
> > 
> > I've found this by pure chance while grepping for pgalloc.h
> > It's been there since 2011, but I don't think it's a stable material, so I
> > didn't cc them.
> > 
> >   arch/m68k/mm/mcfmmu.c | 5 -----
> >   1 file changed, 5 deletions(-)
> > 
> > diff --git a/arch/m68k/mm/mcfmmu.c b/arch/m68k/mm/mcfmmu.c
> > index 29f47923aa46..cb9f8675d81b 100644
> > --- a/arch/m68k/mm/mcfmmu.c
> > +++ b/arch/m68k/mm/mcfmmu.c
> > @@ -214,11 +214,6 @@ void __init cf_mmu_context_init(void)
> >   /*
> >    * Steal a context from a task that has one at the moment.
> > - * This is only used on 8xx and 4xx and we presently assume that
> > - * they don't do SMP.  If they do then thicfpgalloc.hs will have to check
> > - * whether the MM we steal is in use.
> > - * We also assume that this is only used on systems that don't
> > - * use an MMU hash table - this is true for 8xx and 4xx.
> >    * This isn't an LRU system, it just frees up each context in
> >    * turn (sort-of pseudo-random replacement :).  This would be the
> >    * place to implement an LRU scheme if anyone was motivated to do it.
> > 

-- 
Sincerely yours,
Mike.