Re: [PATCH v2 07/15] parisc: use legacy_timer_tick

Arnd Bergmann
2020-10-30T19:35:22Z

On Fri, Oct 30, 2020 at 6:13 PM Helge Deller <deller@gmx.de> wrote:
>
> On 10/30/20 4:17 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > parisc has selected CONFIG_GENERIC_CLOCKEVENTS since commit 43b1f6abd590
> > ("parisc: Switch to generic sched_clock implementation"), but does not
> > appear to actually be using it, and instead calls the low-level
> > timekeeping functions directly.
>
> Arnd, thank you for this patch!
> It reminded me that I really missed to fully implement the clockevents on parisc!
>
> Your other patch ("RFC: m68k: mac: convert to generic clockevent")
> was a big help too, as it showed how it might work on parisc as well.
>
> Here is now a current version of the clockevents-enabling-patch for parisc:
> https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?h=for-next&id=3b7ab4a74a2d1972dbeb33285d85f1500b2ff96a

Ah, nice!

> > Remove the GENERIC_CLOCKEVENTS select again, and instead convert to
> > the newly added legacy_timer_tick() helper.
>
> My patch still needs more testing, but if it turns to work
> out right, would you mind to drop your patch for parisc?

I think it would be easier if you could base your patch on top of
my series, as they would otherwise inevitably conflict. I could either
add it to my tree, or you could merge my branch into your tree.

Arnd