Re: [PATCH v3 4/5] can: flexcan: update Kconfig to allow non-of cases

Angelo Dureghello
2021-06-26T12:19:18Z

Hi Marc, Geert,

thanks, fixed all, but i am still fighting on an
occasional strange heisenbug.

After several hours of "candump can0" on coldfire and
"cangen can0" from PC (peak_usb) at 1Mbit/s, coldfire
side suddenly produces a 129 RX errors from one packet
to another 0 -> 129.
In this condition, after reset and reboot, issue seems
to persist, at the first received packet coldfire
produces no ack, i still get 129 rx errors:

[ 18.090000] flexcan flexcan-mcf5441x.0 can0: flexcan_chip_start:
reading mcr=0x60a3020f ctrl=0x052d2056
[ 18.090000] flexcan_irq() ecr=0x00008100 esr=0x0001c912
[ 18.090000] flexcan flexcan-mcf5441x.0 can0: Controller changed from
Error Active State (0) into Error Passive State (2).

Issue seems to disappear again after resoldering the
can transceiver (SN65HVD230).

So it seems some issue with my hw, investigating on
this before v4, need to be fully sure it's not a
driver issue. By oscilloscope, differential signal and
rx signal seems perfect, no rings. Also baudrate seems
nearly perfect.

On 22/06/21 8:54 AM, Marc Kleine-Budde wrote:
> On 22.06.2021 08:52:05, Geert Uytterhoeven wrote:
>>> Probably. What about the original proposed change: "(OF || M5441x) && HAS_IOMEM"?
>>
>> Yeah, the Flexcan might pop up on RISC-V, too.
>> But any new platforms should use OF.
>> Given the Flexcan is probably present on more than just M5441x,
>> I'd go for:
>>
>> depends on OF || COLDFIRE || COMPILE_TEST
>> depends on HAS_IOMEM
>
> Looks good to me!
>
>>>>> So I think there won't be too many configs where the oldconfig question
>>>>> would pop up.
>>>>
>>>> Now it will, as Mr. Torvalds' main machine does not satisfy "ARM || PPC"
>>>> or "OF && HAS_IOMEM", but does "HAS_IOMEM" ;-)
>>>
>>> IC, that would be one question too much :)
>>
>> I do doubt he has CONFIG_CAN enabled ;-)
>
> :D
>
> regards,
> Marc
>

Regards,
angelo