Re: [PATCH v3 4/5] can: flexcan: update Kconfig to allow non-of cases

Marc Kleine-Budde
2021-06-22T06:54:37Z

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

On 22.06.2021 08:52:05, Geert Uytterhoeven wrote:
> > Probably. What about the original proposed change: "(OF || M5441x) && HAS_IOMEM"?
>
> Yeah, the Flexcan might pop up on RISC-V, too.
> But any new platforms should use OF.
> Given the Flexcan is probably present on more than just M5441x,
> I'd go for:
>
> depends on OF || COLDFIRE || COMPILE_TEST
> depends on HAS_IOMEM

Looks good to me!

> > > > So I think there won't be too many configs where the oldconfig question
> > > > would pop up.
> > >
> > > Now it will, as Mr. Torvalds' main machine does not satisfy "ARM || PPC"
> > > or "OF && HAS_IOMEM", but does "HAS_IOMEM" ;-)
> >
> > IC, that would be one question too much :)
>
> I do doubt he has CONFIG_CAN enabled ;-)

:D

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]