Re: [PATCH v3 1/5] can: flexcan: add platform data header

Marc Kleine-Budde
2021-06-21T18:59:49Z

[-- Attachment #1: Type: text/plain, Size: 2038 bytes --]

On 21.06.2021 20:46:11, Angelo Dureghello wrote:
> Add platform data header for flexcan.
>
> Signed-off-by: Angelo Dureghello <angelo@kernel-space.org>
> ---
> Changes for v2:
> - move header file in more proper location
> - remove irq defines
> - change variable types to match driver types
> Changes for v3:
> - rename to more generic flexcan.h
> - reorder struct fields to avoid paddings
> - remove unused big_endian
> ---
> include/linux/can/platform/flexcan.h | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 include/linux/can/platform/flexcan.h
>
> diff --git a/include/linux/can/platform/flexcan.h b/include/linux/can/platform/flexcan.h
> new file mode 100644
> index 000000000000..ab4628ce701b
> --- /dev/null
> +++ b/include/linux/can/platform/flexcan.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright (C) 2021 Angelo Dureghello <angelo@kernel-space.org>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef _PLAT_FLEXCAN_H
> +#define _PLAT_FLEXCAN_H
> +
> +struct mcf_flexcan_platform_data {

please remove the mcf_ prefix

> + u32 clock_frequency;
> + u8 clk_src;
> +};
> +
> +#define FLEXCAN_MCF5411X_MB_CNT_MCF 16
> +
> +#endif /* _PLAT_FLEXCAN_H */
> --
> 2.31.1
>
>

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]