From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
Greg Ungerer <gerg@linux-m68k.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
uClinux development list <uclinux-dev@uclinux.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] m68knommu: remove set_fs()
Date: Mon, 5 Jul 2021 10:56:07 +0200 [thread overview]
Message-ID: <20210705085607.GA6827@lst.de> (raw)
In-Reply-To: <CAMuHMdV4UQaKE7fn0_HhPfHzwEMwouPvqoeW6_V13yebe7ZSQQ@mail.gmail.com>
On Mon, Jul 05, 2021 at 10:44:51AM +0200, Geert Uytterhoeven wrote:
> > --- a/arch/m68k/Kconfig
> > +++ b/arch/m68k/Kconfig
> > @@ -32,7 +32,7 @@ config M68K
> > select NO_DMA if !MMU && !COLDFIRE
> > select OLD_SIGACTION
> > select OLD_SIGSUSPEND3
> > - select SET_FS
> > + select SET_FS if MMU
>
> Probably this should be
>
> select SET_FS if CPU_HAS_ADDRESS_SPACES
>
> instead. Classic m68k (except for good old 68000) has address spaces,
> Coldfire has not.
No, at least not yet. Coldfire and co still rely on set_fs for various
things in the m68k arch code, and also don't provide
__{get,put}_kernel_nofault yet. So wile m68k with CPU_HAS_ADDRESS_SPACES
will probably one of the hardest ports to get rid of set_fs() for,
m68k/mmu without CPU_HAS_ADDRESS_SPACES would be a logical next step.
I could try to whiteboard code some of it, but I'd need help from dedicated
next prev parent reply other threads:[~2021-07-05 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 5:57 RFC: stop implementing set_fs for m68knommu Christoph Hellwig
2021-07-05 5:57 ` [PATCH] m68knommu: remove set_fs() Christoph Hellwig
2021-07-05 8:44 ` Geert Uytterhoeven
2021-07-05 8:56 ` Christoph Hellwig [this message]
2021-07-05 11:33 ` Geert Uytterhoeven
2021-07-05 11:51 ` Christoph Hellwig
2021-07-05 20:39 ` Linus Torvalds
2021-07-06 4:13 ` Christoph Hellwig
2021-07-06 18:36 ` Linus Torvalds
2021-07-07 14:25 ` Christoph Hellwig
2021-07-07 17:41 ` Linus Torvalds
2021-07-08 1:39 ` Michael Schmitz
2021-07-08 3:40 ` Michael Schmitz
2021-07-08 4:14 ` Linus Torvalds
2021-07-08 4:17 ` Christoph Hellwig
2021-07-08 6:33 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705085607.GA6827@lst.de \
--to=hch@lst.de \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox