[PATCH v2 15/15] pd: add error handling support for add_disk()

Luis Chamberlain
2021-09-27T22:02:26Z

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
drivers/block/paride/pd.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
index 500b89a4bdaf..e59759bcf416 100644
--- a/drivers/block/paride/pd.c
+++ b/drivers/block/paride/pd.c
@@ -938,8 +938,12 @@ static int pd_probe_drive(struct pd_unit *disk, int autoprobe, int port,
if (ret)
goto put_disk;
set_capacity(disk->gd, disk->capacity);
- add_disk(disk->gd);
+ ret = add_disk(disk->gd);
+ if (ret)
+ goto cleanup_disk;
return 0;
+cleanup_disk:
+ blk_cleanup_disk(disk->gd);
put_disk:
put_disk(p);
disk->gd = NULL;
--
2.30.2