Re: [PATCH v2 03/45] notifier: Add atomic/blocking_notifier_has_unique_priority()

Dmitry Osipenko
2021-10-28T21:32:49Z

28.10.2021 14:00, Andy Shevchenko пишет:
> On Thu, Oct 28, 2021 at 12:16:33AM +0300, Dmitry Osipenko wrote:
>> Add atomic/blocking_notifier_has_unique_priority() helpers which return
>> true if given handler has unique priority.
>
> ...
>
>> +/**
>> + * atomic_notifier_has_unique_priority - Checks whether notifier's priority is unique
>> + * @nh: Pointer to head of the atomic notifier chain
>> + * @n: Entry in notifier chain to check
>> + *
>> + * Checks whether there is another notifier in the chain with the same priority.
>> + * Must be called in process context.
>> + *
>> + * Returns true if priority is unique, false otherwise.
>
> Why this indentation?

This is the same doc-comment style used by this file in general. I
haven't tried to invent anything new.

> ...
>
>> + /*
>> + * This code gets used during boot-up, when task switching is
>> + * not yet working and interrupts must remain disabled. At
>
> One space is enough.

This comment is replicated multiple times over this source file. You can
find it before each down_write(). I borrowed the text as-is, for
consistency.