From: Hangyu Hua <hbh25y@gmail.com>
To: geert@linux-m68k.org
Cc: schwab@linux-m68k.org, gerg@linux-m68k.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
Hangyu Hua <hbh25y@gmail.com>
Subject: [PATCH v2 RESEND] m68k/kernel: array out of bound access in process_uboot_commandline
Date: Thu, 13 Jan 2022 09:58:54 +0800 [thread overview]
Message-ID: <20220113015854.9326-1-hbh25y@gmail.com> (raw)
When the size of commandp >= size, array out of bound write occurs because
len == 0.
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
arch/m68k/kernel/uboot.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/m68k/kernel/uboot.c b/arch/m68k/kernel/uboot.c
index 928dbd33fc4a..63eaf3c3ddcd 100644
--- a/arch/m68k/kernel/uboot.c
+++ b/arch/m68k/kernel/uboot.c
@@ -101,5 +101,6 @@ __init void process_uboot_commandline(char *commandp, int size)
}
parse_uboot_commandline(commandp, len);
- commandp[len - 1] = 0;
+ if (len > 0)
+ commandp[len - 1] = 0;
}
--
2.25.1
next reply other threads:[~2022-01-13 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 1:58 Hangyu Hua [this message]
2022-01-17 4:03 ` [PATCH v2 RESEND] m68k/kernel: array out of bound access in process_uboot_commandline Greg Ungerer
2022-01-18 2:18 ` Hangyu Hua
[not found] <9775e266-5fee-b0e9-7fa3-b602ec4b7796 () gmail ! com>
2022-01-18 8:26 ` Greg Ungerer
2022-01-18 10:40 ` Hangyu Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113015854.9326-1-hbh25y@gmail.com \
--to=hbh25y@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox