Re: [PATCH v16 1/4] tty: goldfish: introduce gf_ioread32()/gf_iowrite32()

Greg KH
2022-04-07T04:49:02Z

On Wed, Apr 06, 2022 at 10:15:20PM +0200, Laurent Vivier wrote:
> Revert
> commit da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()")
>
> and define gf_ioread32()/gf_iowrite32() to be able to use accessors
> defined by the architecture.
>
> Cc: stable@vger.kernel.org # v5.11+
> Fixes: da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()")
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/tty/goldfish.c | 20 ++++++++++----------
> include/linux/goldfish.h | 15 +++++++++++----
> 2 files changed, 21 insertions(+), 14 deletions(-)
>

Why is this a commit for the stable trees? What bug does it fix? You
did not describe the problem in the changelog text at all, this looks
like a housekeeping change only.

thanks,

greg k-h