From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE49C433EF for ; Tue, 7 Jun 2022 15:51:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245690AbiFGPv0 (ORCPT ); Tue, 7 Jun 2022 11:51:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344312AbiFGPvO (ORCPT ); Tue, 7 Jun 2022 11:51:14 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44A8EF33A0 for ; Tue, 7 Jun 2022 08:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654617073; x=1686153073; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MXX2ICA24DJPqQzW39/5fG5pFbojGgZxe/8CqlkXkBI=; b=XLuO7twy+S/TBVnlEGy8MfexW01yZitxopHiERBAPB2J555q++Su85BJ Fh9L00fxH0ofdeM/NyFb6LzKTUxantRIth7tIEwRnj1hS9dOi6RR0WeBQ 9nSeSwTo6S1PKhQfWMWbJeWCeFA21XoEo1PSvbhGrmDi8MMNDzEdz+FNJ 2dz+iuBO07Oq0QoqadSwtg4QFfw1tghV+EGyFy3ySYKd2ubXy+4CdZxCz cR9oiVKTeHNS3Z1oyt/IZtt3ahhIeo91TxUIwhYg0Ty0M5D6xmDbM+1Xt EuquJP3UbCtghOMjEZnQu7/zEhPPnuksregxTwR6SuINFgsq8wPSKKd4k w==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="265212043" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="265212043" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 08:49:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="648084807" Received: from irvmail001.ir.intel.com ([10.43.11.63]) by fmsmga004.fm.intel.com with ESMTP; 07 Jun 2022 08:48:59 -0700 Received: from newjersey.igk.intel.com (newjersey.igk.intel.com [10.102.20.203]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 257FmwHR030702; Tue, 7 Jun 2022 16:48:58 +0100 From: Alexander Lobakin To: Geert Uytterhoeven Cc: Alexander Lobakin , Arnd Bergmann , Yury Norov , "Andy Shevchenko" , Richard Henderson , Matt Turner , Brian Cain , Yoshinori Sato , Rich Felker , "David S. Miller" , Kees Cook , "Peter Zijlstra (Intel)" , Marco Elver , Borislav Petkov , Tony Luck , Greg Kroah-Hartman , alpha , "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , linux-m68k , Linux-sh list , sparclinux , Linux-Arch , "Linux Kernel Mailing List" Subject: Re: [PATCH 0/6] bitops: let optimize out non-atomic bitops on compile-time constants Date: Tue, 7 Jun 2022 17:47:59 +0200 Message-Id: <20220607154759.43549-1-alexandr.lobakin@intel.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: <20220606114908.962562-1-alexandr.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org From: Geert Uytterhoeven Date: Tue, 7 Jun 2022 14:45:41 +0200 > Hi Alexander, Hi! > > On Mon, Jun 6, 2022 at 1:50 PM Alexander Lobakin > wrote: > > While I was working on converting some structure fields from a fixed > > type to a bitmap, I started observing code size increase not only in > > places where the code works with the converted structure fields, but > > also where the converted vars were on the stack. That said, the > > following code: > > > > DECLARE_BITMAP(foo, BITS_PER_LONG) = { }; // -> unsigned long foo[1]; > > unsigned long bar = BIT(BAR_BIT); > > unsigned long baz = 0; > > > > __set_bit(FOO_BIT, foo); > > baz |= BIT(BAZ_BIT); > > > > BUILD_BUG_ON(!__builtin_constant_p(test_bit(FOO_BIT, foo)); > > BUILD_BUG_ON(!__builtin_constant_p(bar & BAR_BIT)); > > BUILD_BUG_ON(!__builtin_constant_p(baz & BAZ_BIT)); > > > > triggers the first assertion on x86_64, which means that the > > compiler is unable to evaluate it to a compile-time initializer > > when the architecture-specific bitop is used even if it's obvious. > > I found that this is due to that many architecture-specific > > non-atomic bitop implementations use inline asm or other hacks which > > are faster or more robust when working with "real" variables (i.e. > > fields from the structures etc.), but the compilers have no clue how > > to optimize them out when called on compile-time constants. > > > > So, in order to let the compiler optimize out such cases, expand the > > test_bit() and __*_bit() definitions with a compile-time condition > > check, so that they will pick the generic C non-atomic bitop > > implementations when all of the arguments passed are compile-time > > constants, which means that the result will be a compile-time > > constant as well and the compiler will produce more efficient and > > simple code in 100% cases (no changes when there's at least one > > non-compile-time-constant argument). > > The condition itself: > > > > if ( > > __builtin_constant_p(nr) && /* <- bit position is constant */ > > __builtin_constant_p(!!addr) && /* <- compiler knows bitmap addr is > > always either NULL or not */ > > addr && /* <- bitmap addr is not NULL */ > > __builtin_constant_p(*addr) /* <- compiler knows the value of > > the target bitmap */ > > ) > > /* then pick the generic C variant > > else > > /* old code path, arch-specific > > > > I also tried __is_constexpr() as suggested by Andy, but it was > > always returning 0 ('not a constant') for the 2,3 and 4th > > conditions. > > > > The savings on x86_64 with LLVM are insane (.text): > > > > $ scripts/bloat-o-meter -c vmlinux.{base,test} > > add/remove: 72/75 grow/shrink: 182/518 up/down: 53925/-137810 (-83885) > > > > $ scripts/bloat-o-meter -c vmlinux.{base,mod} > > add/remove: 7/1 grow/shrink: 1/19 up/down: 1135/-4082 (-2947) > > > > $ scripts/bloat-o-meter -c vmlinux.{base,all} > > add/remove: 79/76 grow/shrink: 184/537 up/down: 55076/-141892 (-86816) > > Thank you! > > I gave it a try on m68k, and am a bit disappointed seeing an increase > in code size: > > add/remove: 49/13 grow/shrink: 279/138 up/down: 6434/-3342 (3092) Ufff, that sucks =\ Could you please try to compile the following code snippet (with the series applied)? unsigned long map; bitmap_zero(&map, BITS_PER_LONG); __set_bit(1, &map); BUILD_BUG_ON(!__builtin_constant_p(map)); If it fails during the vmlinux linkage, it will mean that on your architecture/setup the compiler is unable to optimize the generic implementations to compile-time constants and I'll need to debug this more (probably via some compiler explorer). You could also check the vmlinux size after applying each patch to see which one does this if you feel like it :) > > This is atari_defconfig on a tree based on v5.19-rc1, with > m68k-linux-gnu-gcc (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0, GNU ld (GNU > Binutils for Ubuntu) 2.34). > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Thanks, Olek