Re: [PATCH v1 2/4] m68k - set up platform device for mvme147_scsi

Michael Schmitz
2022-07-11T04:11:58Z

Hi Arnd,

thanks for your review!

Am 11.07.2022 um 03:56 schrieb Arnd Bergmann:
> On Sat, Jul 9, 2022 at 2:10 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> +
>> +static const struct resource mvme147_scsi_rsrc[] __initconst = {
>> + DEFINE_RES_MEM(MVME147_SCSI_BASE, 0xff),
>> + DEFINE_RES_IRQ(MVME147_IRQ_SCSI_PORT),
>> +};
>
> The size should almost certainly be 0x100, not 0xff here.

OK, will fix that. The resource size is taken from one of the Amiga
drivers and might be excessive for mvme147, but 0xff is certainly odd.

Cheers,

Michael

> Otherwise this looks good to me.
>
> Arnd
>