public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org,
	linux-kernel@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH 2/2] m68k: virt: generate new RNG seed on reboot
Date: Wed, 21 Sep 2022 20:52:08 +0200	[thread overview]
Message-ID: <20220921185208.3549140-2-Jason@zx2c4.com> (raw)
In-Reply-To: <20220921185208.3549140-1-Jason@zx2c4.com>

Rather than rebooting into a system with no entropy, regenerate the RNG
seed before rebooting, so that the new system has a fresh seed.

Fixes: a1ee38ab1a75 ("m68k: virt: Use RNG seed from bootinfo block")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 arch/m68k/virt/config.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/m68k/virt/config.c b/arch/m68k/virt/config.c
index 4ab22946ff68..c41d2277de95 100644
--- a/arch/m68k/virt/config.c
+++ b/arch/m68k/virt/config.c
@@ -45,10 +45,18 @@ static void virt_halt(void)
 		;
 }
 
+static struct bi_record *rng_seed_record;
+
 static void virt_reset(void)
 {
 	void __iomem *base = (void __iomem *)virt_bi_data.ctrl.mmio;
 
+	if (rng_seed_record && rng_seed_record->size > sizeof(*rng_seed_record) + 2) {
+		u16 len = rng_seed_record->size - sizeof(*rng_seed_record) - 2;
+		get_random_bytes((u8 *)rng_seed_record->data + 2, len);
+		*(u16 *)rng_seed_record->data = len;
+	}
+
 	iowrite32be(CMD_RESET, base + VIRT_CTRL_REG_CMD);
 	local_irq_disable();
 	while (1)
@@ -101,6 +109,8 @@ int __init virt_parse_bootinfo(const struct bi_record *record)
 		 * length to prevent kexec from using it.
 		 */
 		memzero_explicit((void *)data, len + 2);
+		 /* Store a reference to be filled in on reboot. */
+		rng_seed_record = (void *)record;
 		break;
 	}
 	default:
-- 
2.37.3


  reply	other threads:[~2022-09-21 18:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 18:52 [PATCH 1/2] m68k: process bootinfo records before saving them Jason A. Donenfeld
2022-09-21 18:52 ` Jason A. Donenfeld [this message]
2022-09-23 11:30   ` [PATCH 2/2] m68k: virt: generate new RNG seed on reboot Geert Uytterhoeven
2022-09-23 11:53     ` Jason A. Donenfeld
2022-09-23 12:23       ` Geert Uytterhoeven
2022-09-23 12:26         ` Jason A. Donenfeld
2022-09-23 12:50           ` Geert Uytterhoeven
2022-09-23 13:10             ` Laurent Vivier
2022-09-26 12:02               ` Jason A. Donenfeld
2022-09-26 12:52                 ` Laurent Vivier
2022-09-26 12:56                   ` Jason A. Donenfeld
2022-09-26 13:02                     ` Laurent Vivier
2022-09-26 13:04                       ` Jason A. Donenfeld
2022-09-26 13:10                         ` Laurent Vivier
2022-09-26 13:12                           ` Jason A. Donenfeld
2022-09-26 13:13                         ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921185208.3549140-2-Jason@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox