From: Michael Schmitz <schmitzmic@gmail.com>
To: linux-m68k@vger.kernel.org, geert@linux-m68k.org
Cc: glaubitz@physik.fu-berlin.de
Subject: [PATCH v13 0/3] Add kernel seccomp support for m68k
Date: Thu, 12 Jan 2023 16:55:26 +1300 [thread overview]
Message-ID: <20230112035529.13521-1-schmitzmic@gmail.com> (raw)
Previous version of patch 1 did overwrite a syscall return
value that was changed by ptrace or seccomp (in regs->d0)
by -ENOSYS when skipping a syscall. Branch directly to
ret_from_syscall instead of falling through to badsys (which
must set -ENOSYS). I'm sure this can be done more elegantly.
Patch 3 used the wrong struct definition for ARCH_REGS - the
kernel ptrace code copies 19 registers (from syscall stack
and switch_stack, pt_regs only contains the 14 from the
syscall stack). Stack overflow ensues.
With these changes, 79 of 94 seccomp_bpf tests now succeed.
Cheers,
Michael
next reply other threads:[~2023-01-12 3:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 3:55 Michael Schmitz [this message]
2023-01-12 3:55 ` [PATCH v13 1/3] m68k/kernel - check syscall_trace_enter() return code on m68k Michael Schmitz
2023-01-22 16:35 ` Geert Uytterhoeven
2023-01-22 16:35 ` Geert Uytterhoeven
2023-01-12 3:55 ` [PATCH v13 2/3] m68k: add kernel seccomp support Michael Schmitz
2023-01-22 16:37 ` Geert Uytterhoeven
2023-01-22 16:40 ` John Paul Adrian Glaubitz
2023-01-22 18:11 ` Michael Schmitz
2023-01-22 18:49 ` Geert Uytterhoeven
2023-01-12 3:55 ` [PATCH v13 3/3] tools/testing - seccomp test fixes for m68k Michael Schmitz
2023-01-22 16:40 ` Geert Uytterhoeven
2023-01-12 6:42 ` [PATCH v13 0/3] Add kernel seccomp support " Michael Schmitz
2023-01-13 17:29 ` John Paul Adrian Glaubitz
2023-01-14 0:00 ` Michael Schmitz
2023-01-16 9:12 ` John Paul Adrian Glaubitz
2023-01-17 2:15 ` Michael Schmitz
2023-01-17 8:08 ` John Paul Adrian Glaubitz
2023-01-17 23:25 ` Michael Schmitz
2023-01-18 8:30 ` John Paul Adrian Glaubitz
2023-01-18 9:43 ` John Paul Adrian Glaubitz
2023-01-18 22:21 ` Michael Schmitz
2023-01-19 9:18 ` John Paul Adrian Glaubitz
2023-01-20 10:45 ` John Paul Adrian Glaubitz
2023-02-27 20:45 ` Kees Cook
2023-03-07 2:57 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112035529.13521-1-schmitzmic@gmail.com \
--to=schmitzmic@gmail.com \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).