public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: linux-block@vger.kernel.org, axboe@kernel.dk
Cc: linux-m68k@vger.kernel.org, geert@linux-m68k.org, hch@lst.de,
	martin@lichtvoll.de, fthain@linux-m68k.org,
	Michael Schmitz <schmitzmic@gmail.com>
Subject: [PATCH v12 0/3] Amiga RDB partition support fixes
Date: Sat, 17 Jun 2023 10:36:13 +1200	[thread overview]
Message-ID: <20230616223616.6002-1-schmitzmic@gmail.com> (raw)

Hi Jens,

the hopefully last version of this patch series, only change
in this version is to change all 32 bit fields in the
affs_hardblocks.h header to __be32 following review comments
by Christoph and Geert.

The simple fix (patch 1) still leaves ample room for overflows in
calculating start address and size of a RDB partition, though
such overflows should only be seen in rather unusual cases.

To address these potential overflows, checks are added in the
third patch of this series. Comments by Geert have been
addressed in full. 

In order to avoid warnings about a cast to a restricted
type (__be32, inside be32_to_cpu()) introduced by the third
patch, the second patch changes the annotation of all 32 bit
fields to __be32 (which is what these fields in the RDB
struct ought to have been in the first instance). 

Reviewed-by tags by Geert and Christoph added. Fixes and
prerequisites for stable backport also added. 

Cheers,

        Michael

Michael Schmitz (3):
  block: fix signed int overflow in Amiga partition support
  block: change annotation of rdb_CylBlocks in affs_hardblocks.h
  block: add overflow checks for Amiga partition support

 block/partitions/amiga.c             | 102 ++++++++++++++++++++++-----
 include/uapi/linux/affs_hardblocks.h |  68 +++++++++---------
 2 files changed, 119 insertions(+), 51 deletions(-)

-- 
2.17.1


             reply	other threads:[~2023-06-16 22:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16 22:36 Michael Schmitz [this message]
2023-06-16 22:36 ` [PATCH v12 1/3] block: fix signed int overflow in Amiga partition support Michael Schmitz
2023-06-16 22:36 ` [PATCH v12 2/3] block: change annotation of rdb_CylBlocks in affs_hardblocks.h Michael Schmitz
2023-06-17 11:08   ` Geert Uytterhoeven
2023-06-18  3:10     ` Michael Schmitz
2023-06-18  7:51       ` Geert Uytterhoeven
2023-06-19  2:53         ` Michael Schmitz
2023-06-16 22:36 ` [PATCH v12 3/3] block: add overflow checks for Amiga partition support Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230616223616.6002-1-schmitzmic@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=fthain@linux-m68k.org \
    --cc=geert@linux-m68k.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=martin@lichtvoll.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox