Re: [PATCH v4 01/13] kexec: consolidate kexec and crash options into kernel/Kconfig.kexec

Eric DeVolder
2023-07-06T12:23:52Z

On 7/6/23 07:18, Arnd Bergmann wrote:
> On Wed, Jul 5, 2023, at 16:19, Eric DeVolder wrote:
>> +
>> +config CRASH_DUMP
>> + bool "kernel crash dumps"
>> + depends on ARCH_SUPPORTS_CRASH_DUMP
>> + select CRASH_CORE
>> + select KEXEC
>
> Today's linux-next now runs into a warning on arm64 and
> presumably others, with the same problem as on arm earlier:
>
> WARNING: unmet direct dependencies detected for KEXEC
> Depends on [n]: ARCH_SUPPORTS_KEXEC [=n]
> Selected by [y]:
> - CRASH_DUMP [=y] && ARCH_SUPPORTS_CRASH_DUMP [=y]
>
> I think the easiest way to make this reliable would be
> this fixup:
>
> diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec
> index d82a7ce59c051..e58ca6128d6ee 100644
> --- a/kernel/Kconfig.kexec
> +++ b/kernel/Kconfig.kexec
> @@ -91,6 +91,7 @@ config KEXEC_JUMP
> config CRASH_DUMP
> bool "kernel crash dumps"
> depends on ARCH_SUPPORTS_CRASH_DUMP
> + depends on ARCH_SUPPORTS_KEXEC
> select CRASH_CORE
> select KEXEC
> help
>
> Arnd

Will do, thanks!
I changed my testing to include allnoconfig and allyesconfig and that revealed some minor issues as
well. Almost there!
eric