From: Arnd Bergmann <arnd@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] m68k: add memcmp() declarartion
Date: Wed, 9 Aug 2023 23:10:50 +0200 [thread overview]
Message-ID: <20230809211057.60514-2-arnd@kernel.org> (raw)
In-Reply-To: <20230809211057.60514-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
There is a global definition of memcmp() that gets built on m68k but is never
used and causes a warning because of the missing prototype:
lib/string.c:671:15: error: no previous prototype for 'memcmp' [-Werror=missing-prototypes]
Add the corresponding declaration to avoid the warning. As far as I understand
the #define to redirect memcmp() to __builtin_memcmp() does not actually do anything
here since this is what it does anyway.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/m68k/include/asm/string.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/m68k/include/asm/string.h b/arch/m68k/include/asm/string.h
index f0f5021d6327d..760cc13acdf41 100644
--- a/arch/m68k/include/asm/string.h
+++ b/arch/m68k/include/asm/string.h
@@ -41,6 +41,7 @@ static inline char *strncpy(char *dest, const char *src, size_t n)
#define __HAVE_ARCH_MEMMOVE
extern void *memmove(void *, const void *, __kernel_size_t);
+extern int memcmp(const void *, const void *, __kernel_size_t);
#define memcmp(d, s, n) __builtin_memcmp(d, s, n)
#define __HAVE_ARCH_MEMSET
--
2.39.2
next prev parent reply other threads:[~2023-08-09 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 21:10 [PATCH 1/2] m68k: define __div64_32() to avoid a warning Arnd Bergmann
2023-08-09 21:10 ` Arnd Bergmann [this message]
2023-08-09 21:28 ` [PATCH 2/2] m68k: add memcmp() declarartion John Paul Adrian Glaubitz
2023-08-16 15:42 ` Geert Uytterhoeven
2023-08-16 15:33 ` [PATCH 1/2] m68k: define __div64_32() to avoid a warning Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809211057.60514-2-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox