Re: [PATCH v3 1/2] ata: pata_falcon: fix IO base selection for Q40

Michael Schmitz
2023-08-22T07:27:57Z

Hi Geert,

Am 22.08.2023 um 19:05 schrieb Geert Uytterhoeven:
>>>> + if (base_res) { /* only Q40 has IO resources */
>>>> + io_offset = 0x10000;
>>>> + reg_scale = 1;
>>>> + base = (void __iomem *)base_res->start;
>>>> + ctl_base = (void __iomem *)ctl_res->start;
>>>> +
>>>> + ata_port_desc(ap, "cmd %pa ctl %pa",
>>>> + &base_res->start,
>>>> + &ctl_res->start);
>>> This can be moved outside the else, using %px to format base and
>>> ctl_base.
>>
>> Right - do we need some additional message spelling out what address Q40
>> uses for data transfers? (Redundant for Falcon, of course ...)
>>
>> Though that could be handled outside the else, too:
>>
>> ata_port_desc(ap, "cmd %px ctl %px data %pa",
>> base, ctl_base, &ap->ioaddr.data_addr);
>
> I guess that wouldn't hurt.

Done - I'll send out v4 tomorrow.

Cheers,

Michael

>
> Gr{oetje,eeting}s,
>
> Geert
>