Re: [PATCH] m68k: use kernel's generic libgcc functions

Geert Uytterhoeven
2023-10-05T14:15:45Z

Hi Greg,

On Thu, Oct 5, 2023 at 2:49 AM Greg Ungerer <gerg@linux-m68k.org> wrote:
> On 5/10/23 00:52, Geert Uytterhoeven wrote:
> > I guess we can select GENERIC_LIB_MULDI3 if CPU_HAS_NO_MULDIV64
> > and clean up arch/m68k/lib/muldi3.c, too?
>
> Yes, that is true.
>
> I was hoping we might be able to do something a little more clever.
> The common muldi3.c is almost identical except our local macro for
> umul_ppmm(). But looking at the common lib/muldi3.c code it has been
> setup to handle an arch local definition of that. I didn't spend too much
> time looking at it yet, not sure where we could put that for the whole
> mechanism to work though.

For floating point, there are <math-emu/soft-fp.h> and <asm/sfp-machine.h>,
but abusing that for integer feels wrong.

'git grep "#\s*define\s*umul_ppmm"' shows there are already plenty of
definitions for umul_ppmm(), so moving these to arch-specific header
files can clean that up in the process.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds