From: Greg Ungerer <gerg@linux-m68k.org>
To: linux-m68k@lists.linux-m68k.org
Cc: geert@linux-m68k.org, Greg Ungerer <gerg@linux-m68k.org>
Subject: [PATCH 3/7] m68knommu: coldfire: make mcf_maskimr() static
Date: Wed, 13 Sep 2023 23:44:21 +1000 [thread overview]
Message-ID: <20230913134425.2610927-4-gerg@linux-m68k.org> (raw)
In-Reply-To: <20230913134425.2610927-1-gerg@linux-m68k.org>
When building with W=1:
CC arch/m68k/coldfire/intc.o
arch/m68k/coldfire/intc.c:83:6: warning: no previous prototype for ‘mcf_maskimr’ [-Wmissing-prototypes]
void mcf_maskimr(unsigned int mask)
^~~~~~~~~~~
The mcf_maskimr() function is only used within this file, make it static
to reduce name space pollution and fix warning.
Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
---
arch/m68k/coldfire/intc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/m68k/coldfire/intc.c b/arch/m68k/coldfire/intc.c
index 20c084e932c8..b434371e2b99 100644
--- a/arch/m68k/coldfire/intc.c
+++ b/arch/m68k/coldfire/intc.c
@@ -56,7 +56,7 @@ void mcf_clrimr(int index)
__raw_writew(imr & ~(0x1 << index), MCFSIM_IMR);
}
-void mcf_maskimr(unsigned int mask)
+static void mcf_maskimr(unsigned int mask)
{
u16 imr;
imr = __raw_readw(MCFSIM_IMR);
@@ -80,7 +80,7 @@ void mcf_clrimr(int index)
__raw_writel(imr & ~(0x1 << index), MCFSIM_IMR);
}
-void mcf_maskimr(unsigned int mask)
+static void mcf_maskimr(unsigned int mask)
{
u32 imr;
imr = __raw_readl(MCFSIM_IMR);
--
2.25.1
next prev parent reply other threads:[~2023-09-13 13:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 13:44 [PATCH 0/7] m68knommu: W=1 fixes Greg Ungerer
2023-09-13 13:44 ` [PATCH 1/7] m68knommu: coldfire: add and use "vectors.h" Greg Ungerer
2023-09-13 13:44 ` [PATCH 2/7] m68knommu: coldfire: ensure gpio prototypes visible Greg Ungerer
2023-09-13 13:44 ` Greg Ungerer [this message]
2023-09-13 13:44 ` [PATCH 4/7] m68knommu: coldfire: fix warnings in uboot argument processing Greg Ungerer
2023-09-13 13:44 ` [PATCH 5/7] m68knommu: coldfire: remove unused variable in MMU code Greg Ungerer
2023-09-13 13:44 ` [PATCH 6/7] m68knommu: 68000: fix warnings in 68000 interrupt handling Greg Ungerer
2023-09-13 13:44 ` [PATCH 7/7] m68knommu: 68000: fix warning in timer code Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913134425.2610927-4-gerg@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox