Re: [PATCH 04/22] [RESEND] time: make sysfs_get_uname() function visible in header

Uwe Kleine-König
2023-11-10T18:33:07Z

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

Hello Arnd,

On Wed, Nov 08, 2023 at 01:58:25PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This function is defined globally in clocksource.c and used conditionally
> in clockevent.c, which the declaration hidden when clockevent support

s/which/with/ ?

> is disabled. This causes a harmless warning in the definition:
>
> kernel/time/clocksource.c:1324:9: warning: no previous prototype for 'sysfs_get_uname' [-Wmissing-prototypes]
> 1324 | ssize_t sysfs_get_uname(const char *buf, char *dst, size_t cnt)
>
> Move the declaration out of the #ifdef so it is always visible.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Other than that:

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]