Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype

Geert Uytterhoeven
2023-11-08T20:42:56Z

Hi Arnd,

On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Microblaze runs into a single -Wmissing-prototypes warning when that is
> enabled:
>
> arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype for 'trap_init' [-Wmissing-prototypes]
>
> Include the right header to avoid this.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks for your patch!

> arch/alpha/kernel/traps.c | 1 +
> arch/csky/include/asm/traps.h | 2 --
> arch/csky/kernel/traps.c | 1 +
> arch/m68k/coldfire/vectors.c | 3 +--
> arch/m68k/coldfire/vectors.h | 3 ---

Ah, so this is where the m68k changes listed in the cover letter are
hiding ;-)

> arch/microblaze/kernel/traps.c | 1 +
> arch/sparc/kernel/traps_32.c | 1 +
> arch/sparc/kernel/traps_64.c | 1 +
> arch/x86/include/asm/traps.h | 1 -
> arch/x86/kernel/traps.c | 1 +
> 10 files changed, 7 insertions(+), 8 deletions(-)
> delete mode 100644 arch/m68k/coldfire/vectors.h

Obviously the non-microblaze changes should be spun off in separate
patches.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds