From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] block: pass a phys_addr_t to get_max_segment_size
Date: Sat, 6 Jul 2024 08:22:28 +0200 [thread overview]
Message-ID: <20240706062228.GA13842@lst.de> (raw)
In-Reply-To: <c2333a14-04bc-49be-8cc6-a03dcdb2eec3@kernel.dk>
On Sat, Jul 06, 2024 at 12:21:06AM -0600, Jens Axboe wrote:
> > /**
> > - * get_max_segment_size() - maximum number of bytes to add as a single segment
> > + * get_max_segment_size() - maximum number of bytes to add to a single segment
>
> v1 had this change too, not sure why? The previous description seems
> better than the changed one.
Because it is used to also append data from another bio_vec to a
pre-existing SG segment, not just to create new ones.
next prev parent reply other threads:[~2024-07-06 6:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 12:32 add a bvec_phys helper v2 Christoph Hellwig
2024-07-05 12:32 ` [PATCH 1/2] block: add a bvec_phys helper Christoph Hellwig
2024-07-05 12:32 ` [PATCH 2/2] block: pass a phys_addr_t to get_max_segment_size Christoph Hellwig
2024-07-06 6:21 ` Jens Axboe
2024-07-06 6:22 ` Christoph Hellwig [this message]
2024-07-06 6:24 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2024-07-06 7:52 add a bvec_phys helper v3 Christoph Hellwig
2024-07-06 7:52 ` [PATCH 2/2] block: pass a phys_addr_t to get_max_segment_size Christoph Hellwig
2024-07-06 10:37 ` Chaitanya Kulkarni
2024-07-07 6:40 ` Christoph Hellwig
2024-07-09 12:39 ` Geert Uytterhoeven
2024-07-10 5:52 ` Christoph Hellwig
2024-07-10 7:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240706062228.GA13842@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox