Re: [PATCH 2/2] block: pass a phys_addr_t to get_max_segment_size

Christoph Hellwig
2024-07-06T06:22:31Z

On Sat, Jul 06, 2024 at 12:21:06AM -0600, Jens Axboe wrote:
> > /**
> > - * get_max_segment_size() - maximum number of bytes to add as a single segment
> > + * get_max_segment_size() - maximum number of bytes to add to a single segment
>
> v1 had this change too, not sure why? The previous description seems
> better than the changed one.

Because it is used to also append data from another bio_vec to a
pre-existing SG segment, not just to create new ones.