From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95FE31F6674 for ; Tue, 3 Dec 2024 14:37:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=139.178.84.217 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236650; cv=none; b=QQraRH4RKp6JZ+F94F76jciO22RQvPZzihDt7Pf/+Oc7UPz3H4eFWLkqxEMIuLS1sLMWDeEPMIlPb7dkpIxt5fPfe024ISh2w5lhYk84aD/wRtIJMhOVt1CWia0mMkr058lx6fUtIMxNNqDOrFe01BcUDOYVKAFnmpgBpg1Q4kE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236650; c=relaxed/simple; bh=KqCjLbbr7uGZHzJYP5r1vC+s4HUILcFZeOIULk/tynU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PU4L9JmqkpTyFKu30qnDHzP5qem77SYkT9hq20xya3zZG8WgtCawxH3iTZ7i3LACr2S5eMbe89mVqVMAlPmgKJjh69zPFGdwjKjQLtFTDJdk+MfRLwe2XB4YXYf7vy6Hqsi9Ea3Z8RSDUKwUmWa53DaZgFonxhlC0vF73Q/BhWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=knP2I2nX; arc=none smtp.client-ip=139.178.84.217 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="knP2I2nX" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B2FA75C59B9; Tue, 3 Dec 2024 14:36:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEB18C4CECF; Tue, 3 Dec 2024 14:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733236647; bh=KqCjLbbr7uGZHzJYP5r1vC+s4HUILcFZeOIULk/tynU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=knP2I2nXnjanaV6CkzWrgXEH8shXg4Ll9SeEpsV0hD13oBeZ5OT9LmIdSfah1odge t4sybPo1l/vR/+nEq4kF0gOLnq22z6ZRGyKHL2zYmJCkfAxUuFXayRznWbHWkf+2Q9 Jc4roChy8WjyhXN8sSX6RczEsA6ix+lwvN6ZVwWs= From: Greg Kroah-Hartman To: stable@vger.kernel.org, Greg Ungerer , Geert Uytterhoeven Cc: Greg Kroah-Hartman , patches@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, Antonio Quartulli , Greg Ungerer , Sasha Levin Subject: [PATCH 4.19 080/138] m68k: coldfire/device.c: only build FEC when HW macros are defined Date: Tue, 3 Dec 2024 15:31:49 +0100 Message-ID: <20241203141926.626846308@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241203141923.524658091@linuxfoundation.org> References: <20241203141923.524658091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Antonio Quartulli [ Upstream commit 63a24cf8cc330e5a68ebd2e20ae200096974c475 ] When CONFIG_FEC is set (due to COMPILE_TEST) along with CONFIG_M54xx, coldfire/device.c has compile errors due to missing MCFEC_* and MCF_IRQ_FEC_* symbols. Make the whole FEC blocks dependent on having the HW macros defined, rather than on CONFIG_FEC itself. This fix is very similar to commit e6e1e7b19fa1 ("m68k: coldfire/device.c: only build for MCF_EDMA when h/w macros are defined") Fixes: b7ce7f0d0efc ("m68knommu: merge common ColdFire FEC platform setup code") To: Greg Ungerer To: Geert Uytterhoeven Cc: linux-m68k@lists.linux-m68k.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Antonio Quartulli Signed-off-by: Greg Ungerer Signed-off-by: Sasha Levin --- arch/m68k/coldfire/device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/m68k/coldfire/device.c b/arch/m68k/coldfire/device.c index 908d58347790d..b900931669adc 100644 --- a/arch/m68k/coldfire/device.c +++ b/arch/m68k/coldfire/device.c @@ -89,7 +89,7 @@ static struct platform_device mcf_uart = { .dev.platform_data = mcf_uart_platform_data, }; -#if IS_ENABLED(CONFIG_FEC) +#ifdef MCFFEC_BASE0 #ifdef CONFIG_M5441x #define FEC_NAME "enet-fec" @@ -141,6 +141,7 @@ static struct platform_device mcf_fec0 = { .platform_data = FEC_PDATA, } }; +#endif /* MCFFEC_BASE0 */ #ifdef MCFFEC_BASE1 static struct resource mcf_fec1_resources[] = { @@ -178,7 +179,6 @@ static struct platform_device mcf_fec1 = { } }; #endif /* MCFFEC_BASE1 */ -#endif /* CONFIG_FEC */ #if IS_ENABLED(CONFIG_SPI_COLDFIRE_QSPI) /* @@ -478,12 +478,12 @@ static struct platform_device mcf_i2c5 = { static struct platform_device *mcf_devices[] __initdata = { &mcf_uart, -#if IS_ENABLED(CONFIG_FEC) +#ifdef MCFFEC_BASE0 &mcf_fec0, +#endif #ifdef MCFFEC_BASE1 &mcf_fec1, #endif -#endif #if IS_ENABLED(CONFIG_SPI_COLDFIRE_QSPI) &mcf_qspi, #endif -- 2.43.0