From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70A5F222D78 for ; Thu, 12 Dec 2024 17:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=147.75.193.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024157; cv=none; b=U3+F3S0vT/Bd3QCKz+bmpP2q289bS8YlXn3mXDLwMFMOvXGCLTWGENVz76OqqDGuRytUOSkPn9IdAbN2vhfZW1oHeUaXOiIJmnIlTvUhFA91x+pijJk5vJbxRQaW//1K4Ip4wG2hkuadAblrzdUrezfRPIWDCpu55SXY15JAEuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734024157; c=relaxed/simple; bh=nTmx4Tf57aWog6neNo4oFaLcLRI4nOLvd9nkx52e//I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V8RexZZcZzWdC+eBoW0o7Y2Of62mvl6cGlSrUIX1IvtQM1QhynqJ5niVJQIMQrkbnVQ105mRWT6oOOhBkBe//Jl7MtRmfUh8oLtjxv77LqxdwmxEvosaQiZNlzrT6K8vSyakkMaAn31KicDZAMWyc85SUnO31lqfR0viGBGDJ2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=F2a6Nhiv; arc=none smtp.client-ip=147.75.193.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="F2a6Nhiv" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 368B4A41D69; Thu, 12 Dec 2024 17:20:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7295C4CED4; Thu, 12 Dec 2024 17:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734024154; bh=nTmx4Tf57aWog6neNo4oFaLcLRI4nOLvd9nkx52e//I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F2a6NhivskaeKneJncKTHKJXBNqL8sL4WPrPgaxsRefb8WYFi51+v8qEtwi7afog/ PZV7h/Fgj0vXyAPJf9H+PO8bihy8yRaJqUf+1+l4Ahyrzb0yZ7k/ark3hlBg7rIN6Z Dac65NJ03gD+oIyk6A+z4SmfYIekvn0EKXEpWQes= From: Greg Kroah-Hartman To: stable@vger.kernel.org, Greg Ungerer , Geert Uytterhoeven Cc: Greg Kroah-Hartman , patches@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, Antonio Quartulli , Greg Ungerer , Sasha Levin Subject: [PATCH 5.10 203/459] m68k: coldfire/device.c: only build FEC when HW macros are defined Date: Thu, 12 Dec 2024 15:59:01 +0100 Message-ID: <20241212144301.587080996@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241212144253.511169641@linuxfoundation.org> References: <20241212144253.511169641@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Antonio Quartulli [ Upstream commit 63a24cf8cc330e5a68ebd2e20ae200096974c475 ] When CONFIG_FEC is set (due to COMPILE_TEST) along with CONFIG_M54xx, coldfire/device.c has compile errors due to missing MCFEC_* and MCF_IRQ_FEC_* symbols. Make the whole FEC blocks dependent on having the HW macros defined, rather than on CONFIG_FEC itself. This fix is very similar to commit e6e1e7b19fa1 ("m68k: coldfire/device.c: only build for MCF_EDMA when h/w macros are defined") Fixes: b7ce7f0d0efc ("m68knommu: merge common ColdFire FEC platform setup code") To: Greg Ungerer To: Geert Uytterhoeven Cc: linux-m68k@lists.linux-m68k.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Antonio Quartulli Signed-off-by: Greg Ungerer Signed-off-by: Sasha Levin --- arch/m68k/coldfire/device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/m68k/coldfire/device.c b/arch/m68k/coldfire/device.c index a055616942a1e..d73d90452b123 100644 --- a/arch/m68k/coldfire/device.c +++ b/arch/m68k/coldfire/device.c @@ -93,7 +93,7 @@ static struct platform_device mcf_uart = { .dev.platform_data = mcf_uart_platform_data, }; -#if IS_ENABLED(CONFIG_FEC) +#ifdef MCFFEC_BASE0 #ifdef CONFIG_M5441x #define FEC_NAME "enet-fec" @@ -145,6 +145,7 @@ static struct platform_device mcf_fec0 = { .platform_data = FEC_PDATA, } }; +#endif /* MCFFEC_BASE0 */ #ifdef MCFFEC_BASE1 static struct resource mcf_fec1_resources[] = { @@ -182,7 +183,6 @@ static struct platform_device mcf_fec1 = { } }; #endif /* MCFFEC_BASE1 */ -#endif /* CONFIG_FEC */ #if IS_ENABLED(CONFIG_SPI_COLDFIRE_QSPI) /* @@ -583,12 +583,12 @@ static struct platform_device mcf_esdhc = { static struct platform_device *mcf_devices[] __initdata = { &mcf_uart, -#if IS_ENABLED(CONFIG_FEC) +#ifdef MCFFEC_BASE0 &mcf_fec0, +#endif #ifdef MCFFEC_BASE1 &mcf_fec1, #endif -#endif #if IS_ENABLED(CONFIG_SPI_COLDFIRE_QSPI) &mcf_qspi, #endif -- 2.43.0