[patch 21/38] hamradio: baycom_epp: Remove BAYCOM_DEBUG

Thomas Gleixner
2026-04-10T12:20:15Z

The whole code guarded by BAYCOM_DEBUG is only writing debug values into a
datastructure, but there is no way to ever access them.

Remove the pointless ballast.

This is part of a larger effort to remove get_cycles() usage from
non-architecture code.

Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Cc: Thomas Sailer <t.sailer@alumni.ethz.ch>
Cc: linux-hams@vger.kernel.org
---
drivers/net/hamradio/baycom_epp.c | 51 --------------------------------------
1 file changed, 51 deletions(-)

--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
@@ -44,7 +44,6 @@

/* --------------------------------------------------------------------- */

-#define BAYCOM_DEBUG
#define BAYCOM_MAGIC 19730510

/* --------------------------------------------------------------------- */
@@ -191,18 +190,6 @@ struct baycom_state {

unsigned int ptt_keyed;
struct sk_buff *skb; /* next transmit packet */
-
-#ifdef BAYCOM_DEBUG
- struct debug_vals {
- unsigned long last_jiffies;
- unsigned cur_intcnt;
- unsigned last_intcnt;
- int cur_pllcorr;
- int last_pllcorr;
- unsigned int mod_cycles;
- unsigned int demod_cycles;
- } debug_vals;
-#endif /* BAYCOM_DEBUG */
};

/* --------------------------------------------------------------------- */
@@ -259,26 +246,6 @@ static inline int calc_crc_ccitt(const u

#define tenms_to_flags(bc,tenms) ((tenms * bc->bitrate) / 800)

-/* --------------------------------------------------------------------- */
-
-static inline void baycom_int_freq(struct baycom_state *bc)
-{
-#ifdef BAYCOM_DEBUG
- unsigned long cur_jiffies = jiffies;
- /*
- * measure the interrupt frequency
- */
- bc->debug_vals.cur_intcnt++;
- if (time_after_eq(cur_jiffies, bc->debug_vals.last_jiffies + HZ)) {
- bc->debug_vals.last_jiffies = cur_jiffies;
- bc->debug_vals.last_intcnt = bc->debug_vals.cur_intcnt;
- bc->debug_vals.cur_intcnt = 0;
- bc->debug_vals.last_pllcorr = bc->debug_vals.cur_pllcorr;
- bc->debug_vals.cur_pllcorr = 0;
- }
-#endif /* BAYCOM_DEBUG */
-}
-
/* ---------------------------------------------------------------------- */
/*
* eppconfig_path should be setable via /proc/sys.
@@ -621,13 +588,6 @@ static int receive(struct net_device *de
return ret;
}

-/* --------------------------------------------------------------------- */
-
-#define GETTICK(x) \
-({ \
- x = (unsigned int)get_cycles(); \
-})
-
static void epp_bh(struct work_struct *work)
{
struct net_device *dev;
@@ -635,21 +595,17 @@ static void epp_bh(struct work_struct *w
struct parport *pp;
unsigned char stat;
unsigned char tmp[2];
- unsigned int time1 = 0, time2 = 0, time3 = 0;
int cnt, cnt2;

bc = container_of(work, struct baycom_state, run_work.work);
dev = bc->dev;
if (!bc->work_running)
return;
- baycom_int_freq(bc);
pp = bc->pdev->port;
/* update status */
if (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)
goto epptimeout;
bc->stat = stat;
- bc->debug_vals.last_pllcorr = stat;
- GETTICK(time1);
if (bc->modem == EPP_FPGAEXTSTATUS) {
/* get input count */
tmp[0] = EPP_TX_FIFO_ENABLE|EPP_RX_FIFO_ENABLE|EPP_MODEM_ENABLE|1;
@@ -673,7 +629,6 @@ static void epp_bh(struct work_struct *w
goto epptimeout;
if (transmit(bc, cnt2, stat))
goto epptimeout;
- GETTICK(time2);
if (receive(dev, cnt))
goto epptimeout;
if (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)
@@ -700,7 +655,6 @@ static void epp_bh(struct work_struct *w
}
if (transmit(bc, cnt, stat))
goto epptimeout;
- GETTICK(time2);
/* do receiver */
while ((stat & (EPP_NRAEF|EPP_NRHF)) != EPP_NRHF) {
switch (stat & (EPP_NRAEF|EPP_NRHF)) {
@@ -734,11 +688,6 @@ static void epp_bh(struct work_struct *w
goto epptimeout;
}
}
- GETTICK(time3);
-#ifdef BAYCOM_DEBUG
- bc->debug_vals.mod_cycles = time2 - time1;
- bc->debug_vals.demod_cycles = time3 - time2;
-#endif /* BAYCOM_DEBUG */
schedule_delayed_work(&bc->run_work, 1);
if (!bc->skb)
netif_wake_queue(dev);