From: Thorsten Blum <thorsten.blum@linux.dev>
To: Kees Cook <kees@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
Thorsten Blum <thorsten.blum@linux.dev>
Subject: [PATCH] drivers: dio: replace deprecated strcpy with strscpy in dio_init
Date: Thu, 30 Apr 2026 14:05:33 +0200 [thread overview]
Message-ID: <20260430120532.305308-3-thorsten.blum@linux.dev> (raw)
strcpy() has been deprecated [1] because it performs no bounds checking
on the destination buffer, which can lead to buffer overflows. While the
current code works correctly, replace strcpy() with the safer strscpy()
to follow secure coding best practices.
Indent multiple lines using tabs instead of spaces, and use pr_info()
and avoid continuation logging while at it.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/dio/dio.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index 419b3c13d491..b39ae25d060e 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -178,7 +178,7 @@ static int __init dio_init(void)
if (!MACH_IS_HP300)
return 0;
- printk(KERN_INFO "Scanning for DIO devices...\n");
+ pr_info("Scanning for DIO devices...\n");
/* Initialize the DIO bus */
INIT_LIST_HEAD(&dio_bus.devices);
@@ -247,18 +247,19 @@ static int __init dio_init(void)
dev->id = prid;
dev->ipl = DIO_IPL(va);
- strcpy(dev->name, dio_getname(dev->id));
- printk(KERN_INFO "select code %3d: ipl %d: ID %02X", dev->scode, dev->ipl, prid);
+ strscpy(dev->name, dio_getname(dev->id));
if (DIO_NEEDSSECID(prid))
- printk(":%02X", secid);
- printk(": %s\n", dev->name);
+ pr_info("select code %3d: ipl %d: ID %02X:%02X: %s\n",
+ dev->scode, dev->ipl, prid, secid, dev->name);
+ else
+ pr_info("select code %3d: ipl %d: ID %02X: %s\n",
+ dev->scode, dev->ipl, prid, dev->name);
if (scode >= DIOII_SCBASE)
iounmap(va);
error = device_register(&dev->dev);
if (error) {
- pr_err("DIO: Error registering device %s\n",
- dev->name);
+ pr_err("DIO: Error registering device %s\n", dev->name);
put_device(&dev->dev);
continue;
}
reply other threads:[~2026-04-30 12:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430120532.305308-3-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox