From: Thorsten Blum <thorsten.blum@linux.dev>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
Thorsten Blum <thorsten.blum@linux.dev>
Subject: [PATCH v2 2/2] drivers: dio: use tabs and avoid continuation logging in dio_init
Date: Mon, 4 May 2026 10:18:07 +0200 [thread overview]
Message-ID: <20260504081804.3260-5-thorsten.blum@linux.dev> (raw)
In-Reply-To: <20260504081804.3260-3-thorsten.blum@linux.dev>
Indent multiple lines using tabs instead of spaces. Use pr_info() and
avoid continuation logging.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/dio/dio.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index 4a3ddda97d7c..b39ae25d060e 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -178,7 +178,7 @@ static int __init dio_init(void)
if (!MACH_IS_HP300)
return 0;
- printk(KERN_INFO "Scanning for DIO devices...\n");
+ pr_info("Scanning for DIO devices...\n");
/* Initialize the DIO bus */
INIT_LIST_HEAD(&dio_bus.devices);
@@ -248,17 +248,18 @@ static int __init dio_init(void)
dev->ipl = DIO_IPL(va);
strscpy(dev->name, dio_getname(dev->id));
- printk(KERN_INFO "select code %3d: ipl %d: ID %02X", dev->scode, dev->ipl, prid);
if (DIO_NEEDSSECID(prid))
- printk(":%02X", secid);
- printk(": %s\n", dev->name);
+ pr_info("select code %3d: ipl %d: ID %02X:%02X: %s\n",
+ dev->scode, dev->ipl, prid, secid, dev->name);
+ else
+ pr_info("select code %3d: ipl %d: ID %02X: %s\n",
+ dev->scode, dev->ipl, prid, dev->name);
if (scode >= DIOII_SCBASE)
iounmap(va);
error = device_register(&dev->dev);
if (error) {
- pr_err("DIO: Error registering device %s\n",
- dev->name);
+ pr_err("DIO: Error registering device %s\n", dev->name);
put_device(&dev->dev);
continue;
}
next prev parent reply other threads:[~2026-05-04 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 8:18 [PATCH v2 1/2] drivers: dio: replace deprecated strcpy with strscpy in dio_init Thorsten Blum
2026-05-04 8:18 ` Thorsten Blum [this message]
2026-05-04 9:32 ` [PATCH v2 2/2] drivers: dio: use tabs and avoid continuation logging " Geert Uytterhoeven
2026-05-04 9:31 ` [PATCH v2 1/2] drivers: dio: replace deprecated strcpy with strscpy " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504081804.3260-5-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox