From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7397547F2D3 for ; Tue, 7 Jul 2026 19:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.234.252.31 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783451220; cv=none; b=oQzztIOBlNCrkCNAZuUEE2PBtNFjMo0uYsXWx8o6LDCdgDTzkmR06x6SDPOyPo8Oq0F3IG1uotHqE2VJ0A0/8iw9NHiw7SYrPojLy6F7iNzVT61LxWB7iqwxg3KUUELfLfbBe0YPHA2iopRDNY5thfLeeD3azs4u8r/GkPfJ61s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783451220; c=relaxed/simple; bh=goRZ6vdAUAoHJn+SETkvvubjhiA9uSuH9ibZRWnISuU=; h=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=dYOYY2Zq2zdMhsSIyiwrTa+uFqgGmbX3taVPVjIlZEYlv0Yr8XwVx3b0256n2WFdWYCswIEheUZvUo68pG6gaUgGVORIEaiYHhp6UGBRdqL6/z9bLheD9ZqaN8voj6J5lWL3ByETW4nDMMBr8zNIAbHqZVvgyZGQyU+49rvsZWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z9pGvu6H; arc=none smtp.client-ip=172.234.252.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z9pGvu6H" Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BB45E40166; Tue, 7 Jul 2026 19:06:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF4E71F00A3D; Tue, 7 Jul 2026 19:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783451215; bh=M6M79H685AEiWZ8EuGvrBs5I7Y5P9Ee9ippfe5S1H4o=; h=Date:From:To:Cc:Subject:References; b=Z9pGvu6HNUZ1HEZ1iYllaavjjFKOFgTqadPIozXIv9JGgx2jiaihgSbjZ3dmUzUJU hfjd2RhwbRCe4/RE6GxyfPq09ROnl/NCd1HaUQk2oMKLyHrrLWVUfmEQIWNgG4H0yV BATAOIL2AA4szex3DJbzo2snz+LuHQ5mvQ28B8yiZeSewg4gWEoZdYSbZCcErqheQA uNsdYnJB/6z23NzIIqnXgmHg+EkSOB5aumXG9do1DJbSPpj9mBvOvIqZlR1k7iJd+n ifnsuEaoUlbMIslTJD3wtnmpXeWlKWS3cwSDNZNKQCEZLL2h2iYwy4NYNlzBrzTYMO XibetjyLr85WQ== Date: Tue, 07 Jul 2026 21:06:53 +0200 Message-ID: <20260707190254.392010241@kernel.org> User-Agent: quilt/0.69 From: Thomas Gleixner To: LKML Cc: Peter Zijlstra , Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Mark Rutland , Jinjie Ruan , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, =?UTF-8?q?Michal=20Such=C3=A1nek?= , Jonathan Corbet , linux-doc@vger.kernel.org Subject: [patch 14/18] entry: Make return type of syscall_trace_enter() bool References: <20260707181957.433213175@kernel.org> Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 This prepares for changing the return types of syscall_enter_from_user_mode[_work]() to bool, which in turn separates the decision of invoking the syscall from the syscall number, which might have been changed in the call by ptrace, seccomp, tracing. Signed-off-by: Thomas Gleixner --- include/linux/entry-common.h | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) --- a/include/linux/entry-common.h +++ b/include/linux/entry-common.h @@ -71,8 +71,8 @@ static inline void syscall_enter_audit(s } } -static __always_inline long syscall_trace_enter(struct pt_regs *regs, unsigned long work, - long syscall) +static __always_inline bool syscall_trace_enter(struct pt_regs *regs, unsigned long work, + long *syscall) { /* * Handle Syscall User Dispatch. This must comes first, since @@ -81,7 +81,7 @@ static __always_inline long syscall_trac */ if (work & SYSCALL_WORK_SYSCALL_USER_DISPATCH) { if (syscall_user_dispatch(regs)) - return -1L; + return false; } /* @@ -90,32 +90,32 @@ static __always_inline long syscall_trac * through hrtimer_interrupt(). */ if (work & SYSCALL_WORK_SYSCALL_RSEQ_SLICE) - rseq_syscall_enter_work(syscall); + rseq_syscall_enter_work(*syscall); /* Handle ptrace */ if (work & (SYSCALL_WORK_SYSCALL_TRACE | SYSCALL_WORK_SYSCALL_EMU)) { if (!arch_ptrace_report_syscall_permit_entry(regs) || (work & SYSCALL_WORK_SYSCALL_EMU)) - return -1L; + return false; } /* Do seccomp after ptrace, to catch any tracer changes. */ if (work & SYSCALL_WORK_SECCOMP) { if (!__seccomp_permit_syscall()) - return -1L; + return false; } /* Either of the above might have changed the syscall number */ - syscall = syscall_get_nr(current, regs); + *syscall = syscall_get_nr(current, regs); if (unlikely(work & SYSCALL_WORK_SYSCALL_TRACEPOINT)) { - if (!trace_syscall_enter(regs, &syscall)) - return -1L; + if (!trace_syscall_enter(regs, syscall)) + return false; } - syscall_enter_audit(regs, syscall); + syscall_enter_audit(regs, *syscall); - return syscall; + return true; } /** @@ -145,8 +145,10 @@ static __always_inline long syscall_ente { unsigned long work = READ_ONCE(current_thread_info()->syscall_work); - if (work & SYSCALL_WORK_ENTER) - syscall = syscall_trace_enter(regs, work, syscall); + if (work & SYSCALL_WORK_ENTER) { + if (!syscall_trace_enter(regs, work, &syscall)) + return -1L; + } return syscall; }