Re: [PATCH RFC v2] m68k: remove get_fs()/set_fs()

[Michael Schmitz <schmitzmic@gmail.com>]

Hi Christoph,

On 9/07/21 7:28 am, Michael Schmitz wrote:
>
> On 9/07/21 12:57 am, Christoph Hellwig wrote:
>> I've force pushed a new version to the branch, can you give it a spin?
>
> Still the same fault (can't start init). But as Linus pointed out, 
> your __constant_copy_to_user() is still broken.

Forget that - got my git am munged up (applied yesterday's patch a 
second time, eek).

That patch works fine on a casual test. What you did to 
__constant_copy_to_user() does not appear to matter - but I haven't put 
the system under any kind of stress yet. I'm a little reluctant to do 
that (recovering from a trashed boot disk is a little dicey), I'll 
probably only try that with your changes to __constant_copy_to_user() 
from commit d36105c942e0 backed out.

That still leaves the issue of __constant_copy_to_user() possibly 
returning -EFAULT instead of the number of residual bytes to copy, but 
we can probably live with that for now (__constant_copy_to_user_asm() 
doesn't actually calculate the residual but just sets it to the number 
of bytes originally to be copied, which is the best we can do with the 
scheme used there).

Cheers,

     Michael