From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09FBC25F979 for ; Tue, 20 May 2025 23:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.234.252.31 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747783809; cv=none; b=co61aMNHKuki+yvgRVyxdg+rQALT54u1gqoZFqOLiiOK6w25zSh+TqgMKp9GxVcF5FqHJIVLTm7ZzZCMnGS6rXhMnM+xiBHbuKifCikPmRm9JYwiaRVRpOwdNKAt68+oe7SJpJ8zVHkD7cijYyHg3JDndZEZEHcj22bSDY9gU74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747783809; c=relaxed/simple; bh=/Yn/tU7urG+QqEUQLpNA79C93Cze2XqrbVp4Cz+CeTg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AkkMY2age362d0DHmIkPbSEemvAbvtipD32hTfuf0TmPfn3QnA0xmG0a7cKkMO9nLu90lkMd7eJBfqA/QBKIrndJD0mrZBtjb+5/mrOh/9i1ZAl7ut2Y/sXyVDkAnOb6YhCmpp3Xv1i/QTBRUg17GhAdxrjEVtIx32SmUImKNY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=kernel.org; arc=none smtp.client-ip=172.234.252.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5E5AE49CC8; Tue, 20 May 2025 23:30:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37EB0C4CEE9; Tue, 20 May 2025 23:30:01 +0000 (UTC) Message-ID: <215dd4bf-04fd-4ce3-ad1c-2ede18e6f152@linux-m68k.org> Date: Wed, 21 May 2025 09:29:58 +1000 Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/3] net: phy: fixed_phy: remove irq argument from fixed_phy_add To: Heiner Kallweit , Geert Uytterhoeven , Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Thomas Bogendoerfer , Vladimir Oltean , Doug Berger , Florian Fainelli , Thangaraj Samynathan , Rengarajan Sundararajan , Microchip Linux Driver Support , Andrew Lunn , Andrew Lunn , Russell King - ARM Linux , David Miller , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Broadcom internal kernel review list , linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, Linux USB Mailing List , "netdev@vger.kernel.org" References: <4d4c468e-300d-42c7-92a1-eabbdb6be748@gmail.com> Content-Language: en-US From: Greg Ungerer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Heiner, On 18/5/25 06:34, Heiner Kallweit wrote: > All callers pass PHY_POLL, therefore remove irq argument from > fixed_phy_add(). > > Signed-off-by: Heiner Kallweit > --- > arch/m68k/coldfire/m5272.c | 2 +- > arch/mips/bcm47xx/setup.c | 2 +- > drivers/net/phy/fixed_phy.c | 5 ++--- > include/linux/phy_fixed.h | 5 ++--- > 4 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/arch/m68k/coldfire/m5272.c b/arch/m68k/coldfire/m5272.c > index 734dab657..5b70dfdab 100644 > --- a/arch/m68k/coldfire/m5272.c > +++ b/arch/m68k/coldfire/m5272.c > @@ -119,7 +119,7 @@ static struct fixed_phy_status nettel_fixed_phy_status __initdata = { > static int __init init_BSP(void) > { > m5272_uarts_init(); > - fixed_phy_add(PHY_POLL, 0, &nettel_fixed_phy_status); > + fixed_phy_add(0, &nettel_fixed_phy_status); > clkdev_add_table(m5272_clk_lookup, ARRAY_SIZE(m5272_clk_lookup)); > return 0; > } Acked-by: Greg Ungerer Regards Greg > diff --git a/arch/mips/bcm47xx/setup.c b/arch/mips/bcm47xx/setup.c > index 247be207f..de426a474 100644 > --- a/arch/mips/bcm47xx/setup.c > +++ b/arch/mips/bcm47xx/setup.c > @@ -282,7 +282,7 @@ static int __init bcm47xx_register_bus_complete(void) > bcm47xx_leds_register(); > bcm47xx_workarounds(); > > - fixed_phy_add(PHY_POLL, 0, &bcm47xx_fixed_phy_status); > + fixed_phy_add(0, &bcm47xx_fixed_phy_status); > return 0; > } > device_initcall(bcm47xx_register_bus_complete); > diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c > index c91adf246..34a71f223 100644 > --- a/drivers/net/phy/fixed_phy.c > +++ b/drivers/net/phy/fixed_phy.c > @@ -160,10 +160,9 @@ static int fixed_phy_add_gpiod(unsigned int irq, int phy_addr, > return 0; > } > > -int fixed_phy_add(unsigned int irq, int phy_addr, > - struct fixed_phy_status *status) > +int fixed_phy_add(int phy_addr, struct fixed_phy_status *status) > { > - return fixed_phy_add_gpiod(irq, phy_addr, status, NULL); > + return fixed_phy_add_gpiod(PHY_POLL, phy_addr, status, NULL); > } > EXPORT_SYMBOL_GPL(fixed_phy_add); > > diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h > index 3392c09b5..316bb4ded 100644 > --- a/include/linux/phy_fixed.h > +++ b/include/linux/phy_fixed.h > @@ -17,8 +17,7 @@ struct net_device; > > #if IS_ENABLED(CONFIG_FIXED_PHY) > extern int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier); > -extern int fixed_phy_add(unsigned int irq, int phy_id, > - struct fixed_phy_status *status); > +int fixed_phy_add(int phy_id, struct fixed_phy_status *status); > extern struct phy_device *fixed_phy_register(unsigned int irq, > struct fixed_phy_status *status, > struct device_node *np); > @@ -28,7 +27,7 @@ extern int fixed_phy_set_link_update(struct phy_device *phydev, > int (*link_update)(struct net_device *, > struct fixed_phy_status *)); > #else > -static inline int fixed_phy_add(unsigned int irq, int phy_id, > +static inline int fixed_phy_add(int phy_id, > struct fixed_phy_status *status) > { > return -ENODEV;