Re: [PATCH v6 1/2] m68k/kernel - wire up syscall_trace_enter/leave for m68k

Greg Ungerer
2021-06-29T07:36:03Z

Hi Michael, Geert,

On 29/6/21 5:31 pm, Geert Uytterhoeven wrote:
> Hi Michael,
>
> On Tue, Jun 29, 2021 at 12:16 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> On 28/06/21 7:25 pm, Geert Uytterhoeven wrote:
>>> On Thu, Jun 24, 2021 at 2:46 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>>>> m68k (other than Coldfire) uses syscall_trace for both trace entry
>>>> and trace exit. Seccomp support requires separate entry points for
>>>> trace entry and exit which are already provided for Coldfire.
>>>>
>>>> Replace syscall_trace by syscall_trace_enter and syscall_trace_leave
>>>> in preparation for seccomp support. Check return code of
>>>> syscall_trace_enter(), and skip syscall if -1. Return code will be
>>>> left at what had been set by ptrace or seccomp (in regs->d0).
>>>>
>>>> No regression seen in testing with strace on ARAnyM.
>>>>
>>>> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
>>> b
>>> Thanks for your patch!
>>>
>>>> arch/m68k/kernel/entry.S | 8 +++++---
>>> We need similar changes to arch/m68k/68000/entry.S and
>>> arch/m68k/coldfire/entry.S
>>
>> Do you have a current defconfig for 68000? I've test compiled my patch
>> with two coldfire defconfigs, but could not find one for m68kclassic ...
>
> Unfortunately not.
> Greg?

Sorry, no, I don't have one.
Whenever I need to compile for a 68000 target I manually configure one
("make menuconfig" and friends).

Would be nice to have one in mainline ;-)

Regards
Greg