From: David Howells <dhowells@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
David Huggins-Daines <dhd@debian.org>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nubus: Kill nubus_proc_detach_device()
Date: Sat, 04 May 2013 00:10:16 +0100 [thread overview]
Message-ID: <24064.1367622616@warthog.procyon.org.uk> (raw)
In-Reply-To: <1367612438-26490-1-git-send-email-geert@linux-m68k.org>
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Commit 59d8053f1e16904d54ed7469d4b36801ea6b8f2c ("proc: Move non-public
> stuff from linux/proc_fs.h to fs/proc/internal.h") broke Apple NuBus
> support:
>
> drivers/nubus/proc.c: In function ‘nubus_proc_detach_device’:
> drivers/nubus/proc.c:156: error: dereferencing pointer to incomplete type
> drivers/nubus/proc.c:158: error: dereferencing pointer to incomplete type
>
> Fortunately nubus_proc_detach_device() is unused, and appears to have never
> been used, so just remove it.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Fine by me.
Acked-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2013-05-03 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 20:20 [PATCH] nubus: Kill nubus_proc_detach_device() Geert Uytterhoeven
2013-05-03 23:10 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24064.1367622616@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dhd@debian.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox