From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39206EC875F for ; Fri, 8 Sep 2023 01:05:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239290AbjIHBFz (ORCPT ); Thu, 7 Sep 2023 21:05:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233955AbjIHBFz (ORCPT ); Thu, 7 Sep 2023 21:05:55 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1C841BD6 for ; Thu, 7 Sep 2023 18:05:50 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 40C4B5C01C9; Thu, 7 Sep 2023 21:05:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 07 Sep 2023 21:05:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1694135150; x=1694221550; bh=WmqyT4IFLv9qj H0y30QsEQmethRjFgEsjTygW1IyiXA=; b=DRjkjBnWsc49xHzSgjZXba3yl3ZMr r471ebLtFRXd1N7ePXF61uuOV48ajy4sEVwConnQzv+ujXOikP0cijgJTI5T6XJU eJk1FuIGK7DzaS+KHENdsDGY+bwJAU6zgitbqPMjJvYQ0Jfxgbb6Zy5Bnfyu205x y72zYhq9cPQiEO+Lz8kHXHjE9RI494GB3njvsq3PrtBEuDRpj/5beiqlPqtxqiKL ZAVde3y0G0uesbksFpYUIr9wdFw5caeEBUR5BBpR05OR2TGt1x2xyHv5E8gn6TsM IdItFlw2ra/rCU0lgQFPHiuUIIfkqzoX9cNOyy6qVmS3Ns9zdyXdS1FEA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudehiedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevufgjkfhfgggtsehttdertddttddvnecuhfhrohhmpefhihhnnhcu vfhhrghinhcuoehfthhhrghinheslhhinhhugidqmheikehkrdhorhhgqeenucggtffrrg htthgvrhhnpeelueehleehkefgueevtdevteejkefhffekfeffffdtgfejveekgeefvdeu heeuleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hfthhhrghinheslhhinhhugidqmheikehkrdhorhhg X-ME-Proxy: Feedback-ID: i58a146ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Sep 2023 21:05:47 -0400 (EDT) Date: Fri, 8 Sep 2023 11:05:59 +1000 (AEST) From: Finn Thain To: Michael Schmitz cc: Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Arnd Bergmann , Philip Blundell , Greg Ungerer , Joshua Thompson , Sam Creasey , Laurent Vivier , linux-kernel@vger.kernel.org Subject: Re: [PATCH 22/52] m68k: atari: Add and use "atari.h" In-Reply-To: <6ff868a4-d433-6e92-8bf2-573fee19ce2c@gmail.com> Message-ID: <291d4cb0-e3b8-1e7d-8b34-79aee23865fa@linux-m68k.org> References: <0778d9dd186928666d760d5523c7d2311f781621.1694093327.git.geert@linux-m68k.org> <142e4eb5-b47e-e27c-1be3-bc6c5df889c0@linux-m68k.org> <6ff868a4-d433-6e92-8bf2-573fee19ce2c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Fri, 8 Sep 2023, Michael Schmitz wrote: > > atariints.h already has some prototypes, so yes on that account. > > atarihw.h only has inlines, but sound and time related prototypes could > be added there, too. > > Geert's intentions might have been avoiding inclusion of all the > hardware specific data in those two files, but the only source file to > benefit from this is config.c (the other three already include > atariints.h and atarihw.h). > > OTOH, considering this patch series adds a lot of other headers that > only contain prototypes, it might be better to keep to that pattern > everywhere. > I think Geert's intention may have been to avoid adding definitions to the asm/foo.h headers shipped with "make headers_install". If that's the intention, there would seem to be a mess to be cleaned up, for which I'm partly to blame...