From: Joe Perches <joe@perches.com>
To: Michael Schmitz <schmitzmic@gmail.com>,
linux-m68k@vger.kernel.org, geert@linux-m68k.org
Cc: alex@kazik.de, netdev@vger.kernel.org
Subject: Re: [PATCH net v11 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver
Date: Thu, 18 Nov 2021 11:18:44 -0800 [thread overview]
Message-ID: <2c686a4d3980e2362199162f5baf9d4f4dd5892d.camel@perches.com> (raw)
In-Reply-To: <20211114234005.335-4-schmitzmic@gmail.com>
On Mon, 2021-11-15 at 12:40 +1300, Michael Schmitz wrote:
> Add module parameter, IO mode autoprobe and PCMCIA reset code
> required to support 100 Mbit PCMCIA ethernet cards on Amiga.
[]
> diff --git a/drivers/net/ethernet/8390/apne.c b/drivers/net/ethernet/8390/apne.c
[]
> @@ -119,6 +119,48 @@ static u32 apne_msg_enable;
[]
> + cftuple_len = pcmcia_copy_tuple(CISTPL_CFTABLE_ENTRY, cftuple, 256);
> + if (cftuple_len < 3)
> + return 0;
> +#ifdef DEBUG
> + else
> + print_hex_dump(KERN_WARNING, "cftable: ", DUMP_PREFIX_NONE, 8,
> + sizeof(char), cftuple, cftuple_len, false);
> +#endif
Why KERN_WARNING and why not use print_hex_dump_debug without the #ifdef
[]
> +#ifdef DEBUG
> + pr_info("IO flags: %x\n", cftable_entry.io.flags);
pr_debug ?
next prev parent reply other threads:[~2021-11-18 19:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 23:40 [PATCH v11 0/3] Add APNE PCMCIA 100 Mbit support Michael Schmitz
2021-11-14 23:40 ` [PATCH v11 1/3] m68k: amiga/pcmcia - add 16 bit detection interface to amipcmcia.h Michael Schmitz
2021-11-15 9:59 ` Geert Uytterhoeven
2021-11-17 7:15 ` Michael Schmitz
2021-11-17 14:35 ` Geert Uytterhoeven
2021-11-18 4:58 ` Michael Schmitz
2021-11-18 8:09 ` Geert Uytterhoeven
2021-11-18 19:42 ` Michael Schmitz
2021-11-14 23:40 ` [PATCH v11 2/3] m68k: io_mm.h - add APNE 100 MBit support Michael Schmitz
2021-11-14 23:40 ` [PATCH net v11 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver Michael Schmitz
2021-11-17 14:42 ` Geert Uytterhoeven
2021-11-18 4:58 ` Michael Schmitz
2021-11-18 8:01 ` Geert Uytterhoeven
2021-11-18 19:09 ` Michael Schmitz
2021-11-18 19:18 ` Joe Perches [this message]
2021-11-18 19:35 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c686a4d3980e2362199162f5baf9d4f4dd5892d.camel@perches.com \
--to=joe@perches.com \
--cc=alex@kazik.de \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox