From: "Christoph Lameter (Ampere)" <cl@gentwo.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
Mike Rapoport <rppt@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Kees Cook <keescook@chromium.org>, Jann Horn <jannh@google.com>,
linux-mm@kvack.org, io-uring@vger.kernel.org,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: Fix too strict alignment check in create_cache()
Date: Wed, 20 Nov 2024 09:50:47 -0800 (PST) [thread overview]
Message-ID: <2e704ffc-2e79-27f7-159e-8fe167d5a450@gentwo.org> (raw)
In-Reply-To: <4f70f8d3-4ba5-43dc-af1c-f8e207d27e9f@suse.cz>
On Wed, 20 Nov 2024, Vlastimil Babka wrote:
> >
> > Fixes: aaa736b186239b7d ("io_uring: specify freeptr usage for SLAB_TYPESAFE_BY_RCU io_kiocb cache")
> > Fixes: d345bd2e9834e2da ("mm: add kmem_cache_create_rcu()")
> > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > Closes: https://lore.kernel.org/37c588d4-2c32-4aad-a19e-642961f200d7@roeck-us.net
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Thanks, will add it to slab pull for 6.13.
Note that there are widespread assumptions in kernel code that the
alignment of scalars is the "natural alignment". Other portions of the
kernel may break. The compiler actually goes along with this??
How do you deal with torn reads/writes in such a scenario? Is this UP
only?
next prev parent reply other threads:[~2024-11-20 18:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 12:46 [PATCH] slab: Fix too strict alignment check in create_cache() Geert Uytterhoeven
2024-11-20 12:49 ` Geert Uytterhoeven
2024-11-20 15:00 ` Guenter Roeck
2024-11-20 15:01 ` Jens Axboe
2024-11-20 15:03 ` Vlastimil Babka
2024-11-20 15:14 ` Guenter Roeck
2024-11-20 15:44 ` Vlastimil Babka
2024-11-20 15:50 ` Geert Uytterhoeven
2024-11-20 17:50 ` Christoph Lameter (Ampere) [this message]
2024-11-21 3:51 ` Matthew Wilcox
2024-11-21 8:15 ` Geert Uytterhoeven
2024-11-21 17:23 ` Christoph Lameter (Ampere)
2024-11-21 18:30 ` Guenter Roeck
2024-11-21 18:35 ` Jens Axboe
2024-11-21 18:50 ` Geert Uytterhoeven
2024-11-21 19:08 ` Guenter Roeck
2024-11-21 19:22 ` Guenter Roeck
2024-11-22 9:45 ` Lorenzo Stoakes
2024-11-22 12:55 ` Lorenzo Stoakes
2024-11-22 18:54 ` Christoph Lameter (Ampere)
2024-11-22 0:23 ` Greg Ungerer
2024-11-22 8:12 ` Geert Uytterhoeven
2024-11-22 8:25 ` Max Filippov
2024-11-21 10:19 ` Christian Brauner
2024-11-21 22:02 ` John Paul Adrian Glaubitz
2024-11-22 2:12 ` Finn Thain
2024-11-22 7:55 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e704ffc-2e79-27f7-159e-8fe167d5a450@gentwo.org \
--to=cl@gentwo.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=geert@linux-m68k.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=io-uring@vger.kernel.org \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@roeck-us.net \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox