public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Andreas Schwab <schwab@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] m68knommu: clean up uClinux boot log output
Date: Sat, 10 Sep 2016 14:54:44 +1000	[thread overview]
Message-ID: <2ff08c98-279e-471c-78c3-2509faba05f9@linux-m68k.org> (raw)
In-Reply-To: <CAMuHMdVA=xDfJOe8MMKVdT6UsfDP=cF_y33YEDR_ekDJcXBtxA@mail.gmail.com>

Hi Geert, Andreas,

On 10/09/16 00:45, Geert Uytterhoeven wrote:
> Hi Andreas,
>
> On Fri, Sep 9, 2016 at 4:20 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> On Sep 09 2016, Greg Ungerer <gerg@linux-m68k.org> wrote:
>>
>>> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
>>> index 72d272e..a160695 100644
>>> --- a/arch/m68k/kernel/setup_no.c
>>> +++ b/arch/m68k/kernel/setup_no.c
>>> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
>>>       process_uboot_commandline(&command_line[0], sizeof(command_line));
>>>  #endif /* CONFIG_UBOOT */
>>>
>>> -     printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
>>
>> Do you have any idea what's the significance of ^O here?
>
> You raised my interest, too ;-)
>
> http://mailman.uclinux.org/pipermail/uclinux-dev//2003-March/016122.html

The problem with the reasoning there is that this is not the
first string printed. This is what the boot console looks like
now:

     Linux version 4.8.0-rc5-00014-g5594b01-dirty (gerg@goober) (gcc 
version 5.4.0 (GCC) ) #2 Sat Sep 10 14:44:55 AEST 2016


     uClinux/COLDFIRE(m520x)
     COLDFIRE port done by Greg Ungerer, gerg@snapgear.com
     Flat model support (C) 1998,1999 Kenneth Albanowski, D. Jeff Dionne
     Built 1 zonelists in Zone order, mobility grouping off.  Total 
pages: 4080
     Kernel command line: root=/dev/mtdblock0
     PID hash table entries: 128 (order: -4, 512 bytes)
     Dentry cache hash table entries: 4096 (order: 1, 16384 bytes)
     ....

So you end up with 2 blank lines for no good reason.

And then there is the question of whether CTRL-O is in any way
useful here. I would argue that it is of pretty much no value
these days - if it ever was:

https://en.wikipedia.org/wiki/Shift_Out_and_Shift_In_characters

Regards
Greg

      reply	other threads:[~2016-09-10  4:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09  1:10 [PATCH] m68knommu: clean up uClinux boot log output Greg Ungerer
2016-09-09  6:21 ` Geert Uytterhoeven
2016-09-09  6:47   ` Greg Ungerer
2016-09-09 14:20 ` Andreas Schwab
2016-09-09 14:45   ` Geert Uytterhoeven
2016-09-10  4:54     ` Greg Ungerer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ff08c98-279e-471c-78c3-2509faba05f9@linux-m68k.org \
    --to=gerg@linux-m68k.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox