From: David Howells <dhowells@redhat.com>
To: gerg@uclinux.org
Cc: dhowells@redhat.com, linux-m68k@vger.kernel.org,
uclinux-dev@uclinux.org, geert@linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: include asm/cmpxchg.h in our m68k atomic.h
Date: Sat, 31 Mar 2012 20:28:19 +0100 [thread overview]
Message-ID: <31523.1333222099@redhat.com> (raw)
In-Reply-To: <1333086729-14263-1-git-send-email-gerg@uclinux.org>
<gerg@uclinux.org> wrote:
> From: Greg Ungerer <gerg@uclinux.org>
>
> After commit 9ffc93f203c18a70623f21950f1dd473c9ec48cd ("Remove all
>
> CC init/main.o
> In file included from include/linux/mm.h:15:0,
> from include/linux/ring_buffer.h:5,
> from include/linux/ftrace_event.h:4,
> from include/trace/syscall.h:6,
> from include/linux/syscalls.h:78,
> from init/main.c:16:
> include/linux/debug_locks.h: In function ‘__debug_locks_off’:
> include/linux/debug_locks.h:16:2: error: implicit declaration of function ‘xchg’
>
> There is no indirect inclusions of the new asm/cmpxchg.h for m68k here.
> Looking at most other architectures they include asm/cmpxchg.h in their
> asm/atomic.h. M68k currently does not do this. Including this in atomic.h
> fixes all m68k build problems.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2012-03-31 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 5:52 [PATCH] m68k: include asm/cmpxchg.h in our m68k atomic.h gerg
2012-03-31 19:28 ` David Howells [this message]
2012-03-31 20:01 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31523.1333222099@redhat.com \
--to=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox