Re: [PATCH] m68k: generalize uboot command line support

[Greg Ungerer <gerg@linux-m68k.org>]

Hi Geert,

On 09/09/16 16:20, Geert Uytterhoeven wrote:
> Hi Greg,
> 
> On Fri, Sep 9, 2016 at 3:10 AM, Greg Ungerer <gerg@linux-m68k.org> wrote:
>> --- a/arch/m68k/include/asm/bootinfo.h
>> +++ b/arch/m68k/include/asm/bootinfo.h
>> @@ -22,6 +22,10 @@ extern void save_bootinfo(const struct bi_record *bi);
>>  static inline void save_bootinfo(const struct bi_record *bi) {}
>>  #endif
>>
>> +#ifdef CONFIG_UBOOT
>> +void process_uboot_commandline(char *commandp, int size);
>> +#endif
> 
> What about providing a dummy for the !CONFIG_UBOOT case..
> 
>> --- a/arch/m68k/kernel/setup_mm.c
>> +++ b/arch/m68k/kernel/setup_mm.c
>> @@ -274,6 +274,9 @@ void __init setup_arch(char **cmdline_p)
>>         strncpy(m68k_command_line, CONFIG_BOOTPARAM_STRING, CL_SIZE);
>>         m68k_command_line[CL_SIZE - 1] = 0;
>>  #endif /* CONFIG_BOOTPARAM */
>> +#if defined(CONFIG_UBOOT)
>> +       process_uboot_commandline(&m68k_command_line[0], CL_SIZE);
>> +#endif
> 
> ... so you can drop the #if and #endif here?

Yep, good idea. I'll re-spin with that.

Thanks
Greg