From: Lance Yang <lance.yang@linux.dev>
To: Finn Thain <fthain@linux-m68k.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Eero Tamminen <oak@helsinkinet.fi>,
Kent Overstreet <kent.overstreet@linux.dev>,
amaindex@outlook.com, anna.schumaker@oracle.com,
boqun.feng@gmail.com, ioworker0@gmail.com,
joel.granados@kernel.org, jstultz@google.com,
leonylgao@tencent.com, linux-kernel@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, longman@redhat.com,
mhiramat@kernel.org, mingo@redhat.com, mingzhe.yang@ly.com,
peterz@infradead.org, rostedt@goodmis.org,
senozhatsky@chromium.org, tfiga@chromium.org, will@kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] hung_task: fix warnings caused by unaligned lock pointers
Date: Wed, 8 Oct 2025 21:48:36 +0800 [thread overview]
Message-ID: <3fa8182f-0195-43ee-b163-f908a9e2cba3@linux.dev> (raw)
In-Reply-To: <ba00388c-1d5b-4d95-054d-a6f09af41e7b@linux-m68k.org>
On 2025/10/8 18:12, Finn Thain wrote:
>
> On Wed, 8 Oct 2025, Lance Yang wrote:
>
>>
>> In other words, we are not just fixing the bug reported by Eero and
>> Geert, but correcting the blocker tracking mechanism's flawed assumption
>> for -stable ;)
>>
>> If you feel this doesn't qualify as a fix, I can change the Fixes: tag
>> to point to the original commit that introduced this flawed mechanism
>> instead.
>>
>
> That's really a question for the bug reporters. I don't personally have a
> problem with CONFIG_DETECT_HUNG_TASK_BLOCKER so I can't say whether the
> fix meets the requirements set in
> Documentation/process/stable-kernel-rules.rst. And I still don't know
I'm a bit confused, as I recall you previously stating that "It's wrong
and should be fixed"[1].
To clarify, is your current position that it should be fixed in general,
but the fix should not be backported to -stable?
If so, then I have nothing further to add to this thread and am happy
to let the maintainer @Andrew decide.
> what's meant by "unnecessary warnings in a few unexpected cases".
The blocker tracking mechanism will trigger a warning when it
encounters any unaligned lock pointer (e.g., from a packed struct). I
don't think that is the expected behavior. Instead, it should simply
skip any unaligned pointer it cannot handle. For the stable kernels,
at least, this is the correct behavior.
[1]
https://lore.kernel.org/lkml/6ec95c3f-365b-e352-301b-94ab3d8af73c@linux-m68k.org/
next prev parent reply other threads:[~2025-10-08 13:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 14:52 [PATCH v2 1/1] hung_task: fix warnings caused by unaligned lock pointers Lance Yang
2025-09-09 16:46 ` Kent Overstreet
2025-09-09 16:55 ` John Paul Adrian Glaubitz
2025-09-09 19:02 ` Kent Overstreet
2025-09-10 0:45 ` Finn Thain
2025-09-10 7:34 ` Geert Uytterhoeven
2025-09-10 7:37 ` John Paul Adrian Glaubitz
2025-09-10 0:07 ` Finn Thain
2025-09-10 0:51 ` Kent Overstreet
2025-09-10 1:35 ` Finn Thain
2025-09-10 1:48 ` Kent Overstreet
2025-09-10 6:40 ` Finn Thain
2025-09-10 6:52 ` Andreas Schwab
2025-09-10 7:39 ` John Paul Adrian Glaubitz
2025-09-10 7:45 ` Geert Uytterhoeven
2025-09-10 8:02 ` Finn Thain
2025-09-10 11:26 ` Andreas Schwab
2025-09-10 7:36 ` Geert Uytterhoeven
2025-09-10 11:57 ` Kent Overstreet
2025-10-07 20:56 ` Andrew Morton
2025-10-08 0:40 ` Finn Thain
2025-10-08 3:03 ` Lance Yang
2025-10-08 6:14 ` Finn Thain
2025-10-08 7:09 ` Lance Yang
2025-10-08 7:23 ` Lance Yang
2025-10-08 10:12 ` Finn Thain
2025-10-08 13:48 ` Lance Yang [this message]
2025-10-08 21:55 ` Finn Thain
2025-10-09 2:01 ` Lance Yang
2025-10-09 4:04 ` Andrew Morton
2025-10-09 7:11 ` Geert Uytterhoeven
2025-10-14 10:11 ` David Laight
2025-10-08 12:56 ` Eero Tamminen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fa8182f-0195-43ee-b163-f908a9e2cba3@linux.dev \
--to=lance.yang@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=amaindex@outlook.com \
--cc=anna.schumaker@oracle.com \
--cc=boqun.feng@gmail.com \
--cc=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=ioworker0@gmail.com \
--cc=joel.granados@kernel.org \
--cc=jstultz@google.com \
--cc=kent.overstreet@linux.dev \
--cc=leonylgao@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=longman@redhat.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mingzhe.yang@ly.com \
--cc=oak@helsinkinet.fi \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=stable@vger.kernel.org \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).