Re: [PATCH RFC v2 4/8] m68k: Handle arrivals of multiple signals correctly

[Michael Schmitz <schmitzmic@gmail.com>]

Hi Geert,

thanks for your feedback!

Am 05.02.2024 um 21:10 schrieb Geert Uytterhoeven:
> Hi Michael,
>
> Thanks for your patch!
>
> On Mon, Feb 5, 2024 at 3:32 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> From: Al Viro <viro@zeniv.linux.org.uk>
>
> When submitting a backport, please add lines like
>
>     commit 4bb0bd81ce5e97092dfda6a106d414b703ec0ee8 upstream.

Will do. I did wonder how the original commit could be found to prevent 
duplicates...

On that note - Uli: would you prefer the entire backport series, or only 
those you do not already have?

>> When we have several pending signals, have entered with the kernel
>> with large exception frame *and* have already built at least one
>> sigframe, regs->stkadj is going to be non-zero and regs->format/sr/pc
>> are going to be junk - the real values are in shifted exception stack
>> frame we'd built when putting together the first sigframe.
>>
>> If that happens, subsequent sigframes are going to be garbage.
>> Not hard to fix - just need to find the "adjusted" frame first
>> and look for format/vector/sr/pc in it.
>>
>> MSch: Minor v4.4 backport merge conflict fixes.
>
> Please move this to "[MSch: ...] below...
>
>>
>> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>> Tested-by: Michael Schmitz <schmitzmic@gmail.com>
>> Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>
>> Tested-by: Finn Thain <fthain@linux-m68k.org>
>> Link: https://lore.kernel.org/r/YP2dBIAPTaVvHiZ6@zeniv-ca.linux.org.uk
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> ... i.e. here.

OK.

>
>> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
>
> Good.
> Please add your SoB on all patches you handle, some lack it.

That would have been the ones that did not need any extra handling. But 
I take your point ...

> Thanks a lot for taking care of this!

No matter!

Cheers,

	Michael

>
> Gr{oetje,eeting}s,
>
>                         Geert
>