From: Finn Thain <fthain@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: will@sowerbutts.com, linux-m68k@vger.kernel.org,
rz@linux-m68k.org, geert@linux-m68k.org
Subject: Re: [PATCH RFC v3] m68k/q40: fix IO base selection for Q40 in pata_falcon.c
Date: Wed, 16 Aug 2023 17:37:24 +1000 (AEST) [thread overview]
Message-ID: <44bc64de-8463-5e43-7335-8ea1ffc07cee@linux-m68k.org> (raw)
In-Reply-To: <2371f714-e0a2-7c0e-d811-5b7ea7a6684f@linux-m68k.org>
On Wed, 16 Aug 2023, Finn Thain wrote:
> Given it's a platform device that's only ever instantiated once, you
> could just use the module-scope variable rather than device-scope.
>
I see that atari instantiates one platform device but q40 actually
instantiates two ata ports, and each port has two drives. So it appears
the module parameter would need to have 4 bits.
You could set ap->private_data to pdev. Then pata_falcon_data_xfer() can
use pdev->id and sdev_target->id to find the relevant bit in the module
parameter.
next prev parent reply other threads:[~2023-08-16 7:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 22:32 [PATCH RFC v3] m68k/q40: fix IO base selection for Q40 in pata_falcon.c Michael Schmitz
2023-08-16 0:23 ` Finn Thain
2023-08-16 4:59 ` Michael Schmitz
2023-08-16 5:29 ` Finn Thain
2023-08-16 7:27 ` Michael Schmitz
2023-08-16 7:37 ` Finn Thain [this message]
2023-08-16 8:06 ` Michael Schmitz
2023-08-16 9:04 ` Finn Thain
2023-08-16 10:40 ` Finn Thain
2023-08-16 8:07 ` Geert Uytterhoeven
2023-08-16 19:40 ` Michael Schmitz
2023-08-16 22:36 ` William R Sowerbutts
2023-08-17 1:35 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44bc64de-8463-5e43-7335-8ea1ffc07cee@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rz@linux-m68k.org \
--cc=schmitzmic@gmail.com \
--cc=will@sowerbutts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox