From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Kuvyrkov Subject: Re: [PATCH] Fix siginfo._uid bug Date: Wed, 23 Dec 2009 22:47:50 +0300 Message-ID: <4B3273E6.8030407@codesourcery.com> References: <4AB113C3.1090606@codesourcery.com> <4AB3A4AC.6000703@codesourcery.com> <4AC5BFA8.4040805@codesourcery.com> <4AE5B06C.1090303@codesourcery.com> <10f740e80911191131o4a58c67ejb3073a9c8cb9fd6c@mail.gmail.com> <4B05A0D0.4040401@codesourcery.com> <10f740e80911240501v238f023ahcdab0c1fe8600bf5@mail.gmail.com> <10f740e80912231037ua8724f4s8965b5c5b255ddfd@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050408090001070401030803" Return-path: Received: from mail.codesourcery.com ([38.113.113.100]:35664 "EHLO mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754129AbZLWTry (ORCPT ); Wed, 23 Dec 2009 14:47:54 -0500 In-Reply-To: <10f740e80912231037ua8724f4s8965b5c5b255ddfd@mail.gmail.com> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Geert Uytterhoeven Cc: Andreas Schwab , linux-m68k@vger.kernel.org This is a multi-part message in MIME format. --------------050408090001070401030803 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/23/09 9:37 PM, Geert Uytterhoeven wrote: > On Tue, Nov 24, 2009 at 14:01, Geert Uytterhoeven wrote: >> On Thu, Nov 19, 2009 at 20:47, Maxim Kuvyrkov wrote: ... >>> The question is which solution should we adopt. The patch I posted fixes >>> all current problems with have on our hands. Andreas suggested to move to >>> the generic layout of `struct siginfo' which will make future problems less >>> likely, but this approach may need additional investigation. >> >> If moving to the generic layout decreases the probability of future problems, >> it's the way to go. > > Do we have a patch somewhere? Here it is, the patch is rather simple. I'm swamped at the moment, so I'll appreciate if someone verifies that the kernel runs fine with this patch applied. Regards, -- Maxim Kuvyrkov CodeSourcery maxim@codesourcery.com (650) 331-3385 x724 --------------050408090001070401030803 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="0001-Switch-m68k-to-generic-siginfo-layout.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Switch-m68k-to-generic-siginfo-layout.patch" RnJvbSA4M2VlZTFhMmVjNWY1YmVhZDE2ZjE1MzRkYzdiOGNhYzA1NjYwNjc4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbSBLdXZ5cmtvdiA8bWF4aW1AY29kZXNvdXJj ZXJ5LmNvbT4KRGF0ZTogV2VkLCAyMyBEZWMgMjAwOSAxMToyODo0MiAtMDgwMApTdWJqZWN0 OiBbUEFUQ0hdIFN3aXRjaCBtNjhrIHRvIGdlbmVyaWMgc2lnaW5mbyBsYXlvdXQuCgpUaGlz IHBhdGNoIHN3aXRjaGVzIG02OGsgdG8gZ2VuZXJpYyBzaWdpbmZvIGxheW91dC4gIFRoZSBj dXN0b20gbGF5b3V0Cm9mIG02OGsncyBgc3RydWN0IHNpZ2luZm8nIGhhZCBzZXZlcmFsIGlz c3VlcyBkdWUgdG8gbm90IGNvbnNpZGVyaW5nCmFsaWFzaW5nIG9mIG1lbWJlcnMgaW4gdGhl IHVuaW9uLCBlLmcuLCBfdWlkMzIgd2FzIGF0IGRpZmZlcmVudCBvZmZzZXRzCmluIC5fa2ls bCwgLl9ydCBhbmQgLl9zaWdjaGxkLgoKU2lnbmVkLW9mZi1ieTogTWF4aW0gS3V2eXJrb3Yg PG1heGltQGNvZGVzb3VyY2VyeS5jb20+Ci0tLQogYXJjaC9tNjhrL2luY2x1ZGUvYXNtL3Np Z2luZm8uaCB8ICAgOTEgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t CiAxIGZpbGVzIGNoYW5nZWQsIDAgaW5zZXJ0aW9ucygrKSwgOTEgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvYXJjaC9tNjhrL2luY2x1ZGUvYXNtL3NpZ2luZm8uaCBiL2FyY2gvbTY4 ay9pbmNsdWRlL2FzbS9zaWdpbmZvLmgKaW5kZXggY2E3ZGRlOC4uODUxZDNkNyAxMDA2NDQK LS0tIGEvYXJjaC9tNjhrL2luY2x1ZGUvYXNtL3NpZ2luZm8uaAorKysgYi9hcmNoL202OGsv aW5jbHVkZS9hc20vc2lnaW5mby5oCkBAIC0xLDk3ICsxLDYgQEAKICNpZm5kZWYgX002OEtf U0lHSU5GT19ICiAjZGVmaW5lIF9NNjhLX1NJR0lORk9fSAogCi0jaWZuZGVmIF9fdUNsaW51 eF9fCi0jZGVmaW5lIEhBVkVfQVJDSF9TSUdJTkZPX1QKLSNkZWZpbmUgSEFWRV9BUkNIX0NP UFlfU0lHSU5GTwotI2VuZGlmCi0KICNpbmNsdWRlIDxhc20tZ2VuZXJpYy9zaWdpbmZvLmg+ CiAKLSNpZm5kZWYgX191Q2xpbnV4X18KLQotdHlwZWRlZiBzdHJ1Y3Qgc2lnaW5mbyB7Ci0J aW50IHNpX3NpZ25vOwotCWludCBzaV9lcnJubzsKLQlpbnQgc2lfY29kZTsKLQotCXVuaW9u IHsKLQkJaW50IF9wYWRbU0lfUEFEX1NJWkVdOwotCi0JCS8qIGtpbGwoKSAqLwotCQlzdHJ1 Y3QgewotCQkJX19rZXJuZWxfcGlkX3QgX3BpZDsJLyogc2VuZGVyJ3MgcGlkICovCi0JCQlf X2tlcm5lbF91aWRfdCBfdWlkOwkvKiBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eSAqLwotCQkJ X19rZXJuZWxfdWlkMzJfdCBfdWlkMzI7IC8qIHNlbmRlcidzIHVpZCAqLwotCQl9IF9raWxs OwotCi0JCS8qIFBPU0lYLjFiIHRpbWVycyAqLwotCQlzdHJ1Y3QgewotCQkJdGltZXJfdCBf dGlkOwkJLyogdGltZXIgaWQgKi8KLQkJCWludCBfb3ZlcnJ1bjsJCS8qIG92ZXJydW4gY291 bnQgKi8KLQkJCWNoYXIgX3BhZFtzaXplb2YoIF9fQVJDSF9TSV9VSURfVCkgLSBzaXplb2Yo aW50KV07Ci0JCQlzaWd2YWxfdCBfc2lndmFsOwkvKiBzYW1lIGFzIGJlbG93ICovCi0JCQlp bnQgX3N5c19wcml2YXRlOyAgICAgICAvKiBub3QgdG8gYmUgcGFzc2VkIHRvIHVzZXIgKi8K LQkJfSBfdGltZXI7Ci0KLQkJLyogUE9TSVguMWIgc2lnbmFscyAqLwotCQlzdHJ1Y3Qgewot CQkJX19rZXJuZWxfcGlkX3QgX3BpZDsJLyogc2VuZGVyJ3MgcGlkICovCi0JCQlfX2tlcm5l bF91aWRfdCBfdWlkOwkvKiBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eSAqLwotCQkJc2lndmFs X3QgX3NpZ3ZhbDsKLQkJCV9fa2VybmVsX3VpZDMyX3QgX3VpZDMyOyAvKiBzZW5kZXIncyB1 aWQgKi8KLQkJfSBfcnQ7Ci0KLQkJLyogU0lHQ0hMRCAqLwotCQlzdHJ1Y3QgewotCQkJX19r ZXJuZWxfcGlkX3QgX3BpZDsJLyogd2hpY2ggY2hpbGQgKi8KLQkJCV9fa2VybmVsX3VpZF90 IF91aWQ7CS8qIGJhY2t3YXJkcyBjb21wYXRpYmlsaXR5ICovCi0JCQlpbnQgX3N0YXR1czsJ CS8qIGV4aXQgY29kZSAqLwotCQkJY2xvY2tfdCBfdXRpbWU7Ci0JCQljbG9ja190IF9zdGlt ZTsKLQkJCV9fa2VybmVsX3VpZDMyX3QgX3VpZDMyOyAvKiBzZW5kZXIncyB1aWQgKi8KLQkJ fSBfc2lnY2hsZDsKLQotCQkvKiBTSUdJTEwsIFNJR0ZQRSwgU0lHU0VHViwgU0lHQlVTICov Ci0JCXN0cnVjdCB7Ci0JCQl2b2lkICpfYWRkcjsgLyogZmF1bHRpbmcgaW5zbi9tZW1vcnkg cmVmLiAqLwotCQl9IF9zaWdmYXVsdDsKLQotCQkvKiBTSUdQT0xMICovCi0JCXN0cnVjdCB7 Ci0JCQlpbnQgX2JhbmQ7CS8qIFBPTExfSU4sIFBPTExfT1VULCBQT0xMX01TRyAqLwotCQkJ aW50IF9mZDsKLQkJfSBfc2lncG9sbDsKLQl9IF9zaWZpZWxkczsKLX0gc2lnaW5mb190Owot Ci0jZGVmaW5lIFVJRDE2X1NJR0lORk9fQ09NUEFUX05FRURFRAotCi0vKgotICogSG93IHRo ZXNlIGZpZWxkcyBhcmUgdG8gYmUgYWNjZXNzZWQuCi0gKi8KLSN1bmRlZiBzaV91aWQKLSNp ZmRlZiBfX0tFUk5FTF9fCi0jZGVmaW5lIHNpX3VpZAkJX3NpZmllbGRzLl9raWxsLl91aWQz MgotI2RlZmluZSBzaV91aWQxNglfc2lmaWVsZHMuX2tpbGwuX3VpZAotI2Vsc2UKLSNkZWZp bmUgc2lfdWlkCQlfc2lmaWVsZHMuX2tpbGwuX3VpZAotI2VuZGlmCi0KLSNpZmRlZiBfX0tF Uk5FTF9fCi0KLSNpbmNsdWRlIDxsaW51eC9zdHJpbmcuaD4KLQotc3RhdGljIGlubGluZSB2 b2lkIGNvcHlfc2lnaW5mbyhzdHJ1Y3Qgc2lnaW5mbyAqdG8sIHN0cnVjdCBzaWdpbmZvICpm cm9tKQotewotCWlmIChmcm9tLT5zaV9jb2RlIDwgMCkKLQkJbWVtY3B5KHRvLCBmcm9tLCBz aXplb2YoKnRvKSk7Ci0JZWxzZQotCQkvKiBfc2lnY2hsZCBpcyBjdXJyZW50bHkgdGhlIGxh cmdlc3Qga25vdyB1bmlvbiBtZW1iZXIgKi8KLQkJbWVtY3B5KHRvLCBmcm9tLCAzKnNpemVv ZihpbnQpICsgc2l6ZW9mKGZyb20tPl9zaWZpZWxkcy5fc2lnY2hsZCkpOwotfQotCi0jZW5k aWYgLyogX19LRVJORUxfXyAqLwotI2VuZGlmIC8qICFfX3VDbGludXhfXyAqLwotCiAjZW5k aWYKLS0gCjEuNi4yLjQKCg== --------------050408090001070401030803--