From: Greg Ungerer <gerg@snapgear.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, gerg@uclinux.org
Subject: Re: [PATCH] m68k: switch to using asm-generic/hardirq.h
Date: Mon, 20 Sep 2010 15:58:48 +1000 [thread overview]
Message-ID: <4C96F818.3030903@snapgear.com> (raw)
In-Reply-To: <AANLkTimx=kV5x2M3R34eUwTjAJU-F+PceZfvrhAJLQtx@mail.gmail.com>
Hi Geert,
On 20/09/10 02:32, Geert Uytterhoeven wrote:
> On Tue, Sep 7, 2010 at 07:00, Greg Ungerer<gerg@snapgear.com> wrote:
>>
>> Hi All,
>>
>> Is there any reason that the m68k arch cannot use the generic
>> hardirq.h support?
>>
>> It looks to be the same, unless I am missing something.
>
> Unfortunately it's not that simple: the m68k core doesn't use the
> generic hardirq
> code yet. Fixing header files it not enough.
Oh, yeah, I get that.
I did this based on visual inspection of the two files,
arch/m68k/include/asm/hardirq_mm.h and
include/asm-generic/hardirq.h.
They are almost the same (the irq_cpustat_t definition is identical).
Outside of a superfluous definition of ack_bad_irq the only difference
is the include of linux/irq.h. Is this enough to cause problems?
>> If it can then it is simple to merge the non-mmu and mmu
>> versions of hardirq.h.
>
> yeah, one more reason to migrate to generic hardirqs...
Indeed :-)
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
prev parent reply other threads:[~2010-09-20 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 5:00 [PATCH] m68k: switch to using asm-generic/hardirq.h Greg Ungerer
2010-09-19 16:32 ` Geert Uytterhoeven
2010-09-20 5:58 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C96F818.3030903@snapgear.com \
--to=gerg@snapgear.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox